Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @react-visual/contentful #38

Closed
5 of 6 tasks
weotch opened this issue Nov 30, 2023 · 0 comments · Fixed by #40
Closed
5 of 6 tasks

Make @react-visual/contentful #38

weotch opened this issue Nov 30, 2023 · 0 comments · Fixed by #40

Comments

@weotch
Copy link
Member

weotch commented Nov 30, 2023

  • Get assets rendering
  • Get visual entries rendering
  • Finish aspect calculator ... it should only be used when there is width/height in the src ... I think i need a helper specific to it ... or do make the function support on aspect chill about there maybe not needing media
  • Don't auto-set aspect when width and height are provided
  • Update docs
  • Move logic into helper files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant