-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with version 3.4.3 and 3.5.0 on Laravel 4 #77
Comments
I'm using 3.5.0 on a L4.2 project right now without issue. I did recently change some internals regarding finding images in the filesystem. Can you show me what your src_dirs config is and where the files actually are? |
I wonder if it could be #13 that introduced your issue ... |
I've had to revert back to Coppa 3.4.3 to get my application working again |
Well balls, I had no idea those commits were causing issues. I even added more unit tests to try to harden it. If you can let me know particulars of how you use Croppa, like what you put for src_dirs and where the files are actually located and stuff like that, I can try to make some tests around your environment to fix. These are the tests designed to validate filesystem stuff: https://github.com/BKWLD/croppa/blob/master/tests/TestCheckForFile.php |
My setup is really simple...just like this...
No extra config specified |
Ahh, I think the problem is that I'm checking now (#13 and 3.5.0) that the referenced image is within the src_dir from the config file. The default config expects it to be at |
In my case the config is default: 'src_dirs' => array(
App::make('path.public'),
), and images are in |
issue #74 |
Yeah, @sdebacker that sounds different than @JayBizzle 's issue and does sound related to the Response part of the ServiceProvider. However, #74 / #75 fixes an issue that was introduced in 3.6.0 and you're encountering it in 3.5.0. So I'm still stumped. |
Yes, that's strange. I have the same problem with 4.3.4 |
I've been using Croppa for a year now on a couple of Laravel 4.1 sites and suddenly it just stopped producing the quadrant(c).jpg files when I post new images, and is not working properly - images do not render properly in the views only the name shows up. I have not changed anything in my app and am just wondering if you know what could be wrong. |
@zodthepossum can you supply your |
@weotch i guess this is what you need... Input::file('attachment')->move(public_path() . '/upload/images', $image->path);
$image->save(); File locations in public/upload/images |
So you didn't customize Croppa's |
@weotch no i had not done so before, thankyou though it worked! |
@weotch & @sdebacker |
Couple questions:
|
@weotch thank you so much for your help, i managed to get public path working properly and upgraded to 4.3.2 - now all ok! thanks again! |
I had to revert to version 3.4.3 as well to solve the "reference file not found" issue. 'src_dirs' => array( but couldn't solve it in the latest version of Croppa. |
Well, what I'm realizing is that I should have made 3.5 a major point release, I didn't realize my tightening the effect of the Next week I'm going to start on a 4.0 release that will change |
Closing this now that 4.0 is released. There is a new configuration schema (breaking change) that more explicitly expresses how Croppa deals with routes and URLs. |
Very nice new release ! Thanks. |
Version 3.4.3 and 3.5.0 are broken, so with Laravel 4.2 I use v3.4.2.
The package doesn't find the image even if it exists. Probably the stream problem ?
The text was updated successfully, but these errors were encountered: