Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agents improvements and dependencies #78

Merged
merged 19 commits into from
Mar 7, 2019
Merged

Agents improvements and dependencies #78

merged 19 commits into from
Mar 7, 2019

Conversation

gdiazlo
Copy link
Contributor

@gdiazlo gdiazlo commented Mar 6, 2019

  • Make some changes to agents to improve their resilience in some areas.
  • Remove unwanted dependencies.
  • Increase memberlist version.
  • Include a new qedmanager script to manage all services (wip) in development environment

@gdiazlo gdiazlo requested review from panchoh, iknite, jllucas and aalda March 6, 2019 16:51
jllucas
jllucas reviewed Mar 7, 2019
View reviewed changes
gossip/monitor/monitor.go Outdated Show resolved Hide resolved
jllucas
jllucas reviewed Mar 7, 2019
View reviewed changes
go.mod Show resolved Hide resolved
jllucas
jllucas reviewed Mar 7, 2019
View reviewed changes
gossip/config.go Outdated Show resolved Hide resolved
jllucas
jllucas reviewed Mar 7, 2019
View reviewed changes
gossip/agent.go Outdated Show resolved Hide resolved
aalda
aalda reviewed Mar 7, 2019
View reviewed changes
Copy link
Contributor

@aalda aalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalda aalda merged commit f7a99ea into BBVA:master Mar 7, 2019
suizman pushed a commit to jllucas/qed that referenced this pull request Jun 4, 2019
@aalda
Merge pull request BBVA#78 from gdiazlo/agents
1b82ca8 
Agents improvements and dependencies

Former-commit-id: f7a99ea
suizman pushed a commit that referenced this pull request Sep 30, 2019
@aalda
Merge pull request #78 from gdiazlo/agents
addb111 
Agents improvements and dependencies

Former-commit-id: 6050045 [formerly f7a99ea]
Former-commit-id: 1b82ca8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalda aalda aalda left review comments

@jllucas jllucas jllucas left review comments

@panchoh panchoh Awaiting requested review from panchoh

@iknite iknite Awaiting requested review from iknite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdiazlo @jllucas @aalda