Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New hyper tree implementation using batches #71

Merged
merged 27 commits into from
Feb 25, 2019
Merged

New hyper tree implementation using batches #71

merged 27 commits into from
Feb 25, 2019

Conversation

aalda
Copy link
Contributor

@aalda aalda commented Feb 22, 2019

No description provided.

@aalda aalda requested review from panchoh and gdiazlo February 22, 2019 12:16
@codecov-io
Copy link

codecov-io commented Feb 25, 2019 •
edited
Loading

Codecov Report

Merging #71 into master will increase coverage by 6.67%.
The diff coverage is 75.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   61.63%   68.31%   +6.67%     
==========================================
  Files          49       62      +13     
  Lines        2990     3225     +235     
==========================================
+ Hits         1843     2203     +360     
+ Misses        984      879     -105     
+ Partials      163      143      -20
Impacted Files Coverage Δ
gossip/agent.go 57.14% <ø> (ø) ⬆️
balloon/cache/lru.go 0% <0%> (ø) ⬆️
balloon/test_util.go 0% <0%> (ø)
balloon/history/navigation/test_util.go 0% <0%> (ø)
balloon/hyper/navigation/audit.go 0% <0%> (ø)
balloon/hyper/pruning/loader.go 0% <0%> (ø)
balloon/history/pruning/print_visitor.go 0% <0%> (ø)
balloon/hyper/pruning/rebuild.go 0% <0%> (ø)
balloon/balloon.go 78.66% <100%> (-6.67%) ⬇️
balloon/cache/simple.go 70.58% <100%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ace16...2657014. Read the comment docs.

aalda and others added 27 commits February 25, 2019 11:38
@aalda @gdiazlo
Separate history tree from hyper tree
6445c72 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Add new pruners implementation
6aa6af5 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Fix new history tree version
f0effb9 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Add test util for position
364c83b 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Add first version of new hyper batch tree
425e1c2 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Add functions to add padding to byte slices
1854a26 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda
Fix position test
3855655 
Co-authored-by: Gabriel Díaz <[email protected]
@aalda @gdiazlo
Fix version bytes length
3bf8fae 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Add another hyper tree implementation using a stack of operations
17cc74d 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Add more insert tests
e875cb8 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Fix position tests
ab1d01d 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Fix hyper search tests
ad84405 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Implement hyper verification pruner
427e071 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Add hyper proof tests
d6d3d3d 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Complete hyper tree tests
03693e2 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Rename hyper pruning package
17e27a9 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Remove FixedBytes method in hyper position
2f41332 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Remove unnecessary conditions
61d1279 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Implement hyper cache rebuild
a32d4be 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Rename hyper2 package to hyper
395915b 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda @gdiazlo
Fix all integration problems with new balloon version
deec0c9 
Co-authored-by: Gabriel Díaz <[email protected]>
@aalda
Change after function in e2e tests to make agents to leave before clo…
71e0e03 
…sing
@aalda
Lock hyper tree when closing
5c60658
@aalda
Add delay to agent tests
98e69b0
@aalda
Add delays to all e2e tests
d79c9c9
@aalda
Change metrics server port in all agents
b7b694f
@aalda
Change raft port in all raftballoon tests
2657014
@aalda
Copy link
Contributor Author

aalda commented Feb 25, 2019

Finally, tests have run successfully!

@aalda aalda merged commit 91b12cb into BBVA:master Feb 25, 2019
@aalda aalda deleted the separated_trees branch February 26, 2019 09:00
suizman pushed a commit to jllucas/qed that referenced this pull request Jun 4, 2019
@aalda
Merge pull request BBVA#71 from aalda/separated_trees
8f15a9b 
New hyper tree implementation using batches

Former-commit-id: 91b12cb
suizman pushed a commit that referenced this pull request Sep 30, 2019
@aalda
Merge pull request #71 from aalda/separated_trees
bd05624 
New hyper tree implementation using batches

Former-commit-id: 8242ae7 [formerly 91b12cb]
Former-commit-id: 8f15a9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panchoh panchoh Awaiting requested review from panchoh

@gdiazlo gdiazlo Awaiting requested review from gdiazlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalda @codecov-io