Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client #68

Merged
merged 14 commits into from
Feb 21, 2019
Merged

Client #68

merged 14 commits into from
Feb 21, 2019

Conversation

jllucas
Copy link

@jllucas jllucas commented Jan 14, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #68 into master will decrease coverage by 7.2%.
The diff coverage is 48.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   68.83%   61.63%   -7.21%     
==========================================
  Files          49       49              
  Lines        2853     2990     +137     
==========================================
- Hits         1964     1843     -121     
- Misses        717      984     +267     
+ Partials      172      163       -9
Impacted Files Coverage Δ
balloon/history/proof.go 88% <ø> (ø) ⬆️
raftwal/snapshot.go 45.45% <ø> (ø) ⬆️
api/apihttp/apihttp.go 36.52% <0%> (-5.26%) ⬇️
client/config.go 0% <0%> (ø) ⬆️
tests/e2e/setup.go 33.55% <100%> (-50.01%) ⬇️
raftwal/raft.go 61.11% <48.83%> (-0.35%) ⬇️
raftwal/fsm.go 56.55% <52.08%> (-4.68%) ⬇️
client/client.go 59.64% <57.14%> (+3.19%) ⬆️
tests/e2e/test_service.go 0% <0%> (-67.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a392b6...afb3f59. Read the comment docs.

@jllucas jllucas force-pushed the client branch 2 times, most recently from 54103e8 to 933e6c3 Compare January 16, 2019 14:46
@jllucas jllucas requested review from aalda and gdiazlo January 16, 2019 15:30
cmd/client.go Outdated Show resolved Hide resolved
@iknite iknite merged commit bd98a7c into BBVA:master Feb 21, 2019
@iknite iknite deleted the client branch February 21, 2019 12:20
suizman pushed a commit to jllucas/qed that referenced this pull request Jun 4, 2019
suizman pushed a commit that referenced this pull request Sep 30, 2019
Client

Former-commit-id: e90fd08 [formerly bd98a7c]
Former-commit-id: 52b2d57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants