Handle cancel function in metrics server shutdown

BBVA · Apr 10, 2019 · a089e95 · a089e95
1 parent 87a9b0f
commit a089e95
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/metrics/metrics.go b/metrics/metrics.go
@@ -84,7 +84,8 @@ func (m Server) Start() {
 // Shutdown gracefully shutdowns metrics http server waiting 5 seconds for
 // connections to be closed.
 func (m Server) Shutdown() {
-	ctx, _ := context.WithTimeout(context.Background(), 5*time.Second)
+	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
+	defer cancel()
 	m.server.Shutdown(ctx)
 }