Objects with start / stop should not block

BBVA · Apr 10, 2019 · 58844f9 · 58844f9
1 parent 6ec665d
commit 58844f9
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/metrics/metrics.go b/metrics/metrics.go
@@ -74,9 +74,11 @@ func NewServer(addr string) *Server {
 
 // Listens on the configured address and blocks until shutdown is called.
 func (m Server) Start() {
-	if err := m.server.ListenAndServe(); err != http.ErrServerClosed {
-		log.Errorf("Can't start metrics HTTP server: %s", err)
-	}
+	go func() {
+		if err := m.server.ListenAndServe(); err != http.ErrServerClosed {
+			log.Errorf("Can't start metrics HTTP server: %s", err)
+		}
+	}()
 }
 
 // Shutdown gracefully shutdowns metrics http server waiting 5 seconds for