Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] UserNotificationService #197

Open
RadovanTomik opened this issue Mar 2, 2024 · 0 comments
Open

[REFACTOR] UserNotificationService #197

RadovanTomik opened this issue Mar 2, 2024 · 0 comments
Labels
maintenance Necessary upkeep
Milestone
Hackathon, Graz

Comments

@RadovanTomik
Copy link
Collaborator

Clean up the UserNotificationService as the interface is getting too big and the implementation as well. Suggestion would be to simplify the interface to:

List<NotificationModel> getNotifications(Long personId);
NotificationModel createNotification(Long PersonId, String content)
NotificationModel createNotification(Long PersonId, String content, bool sendImmediateEmail)

Create a separate class for sending out pending email notifications.
@RadovanTomik RadovanTomik added the maintenance Necessary upkeep label Mar 2, 2024
@RadovanTomik RadovanTomik added this to the Hackathon, Graz milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Necessary upkeep
Projects
None yet
Milestone
Hackathon, Graz
Development

No branches or pull requests
1 participant
@RadovanTomik