diff --git a/packages/components/psammead-inline-link/CHANGELOG.md b/packages/components/psammead-inline-link/CHANGELOG.md index c8f06492bc..b169c6cb15 100644 --- a/packages/components/psammead-inline-link/CHANGELOG.md +++ b/packages/components/psammead-inline-link/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 1.1.0 | [PR#719](https://github.com/bbc/psammead/pull/719) Updates the link styling to new UX designs | | 1.0.1 | [PR#713](https://github.com/bbc/psammead/pull/713) Update `styled-components` to 4.3.2 | | 1.0.0 | [PR#679](https://github.com/bbc/psammead/pull/679) Bump version number | | 0.3.8 | [PR#498](https://github.com/bbc/psammead/pull/498) Update stories to use new input provider | diff --git a/packages/components/psammead-inline-link/README.md b/packages/components/psammead-inline-link/README.md index 17b18336eb..7d8dbd68a5 100644 --- a/packages/components/psammead-inline-link/README.md +++ b/packages/components/psammead-inline-link/README.md @@ -79,7 +79,7 @@ This component can be used at any point on a page. Since this is just a `` tag with associated styles, when you use this component, it has the same semantic meaning as a regular anchor element. -The font and background-color choices for each hover/focused/visited/default states meet WCAG AA colour contrast guidelines. +The font and background-color choices for each hover/focused/visited/default states meet WCAG AA colour contrast guidelines. Also the border width increases on hover and focus which acts as a visible change that is not colour dependent for high-contrast modes, which often override colours/styles. ## Contributing diff --git a/packages/components/psammead-inline-link/package-lock.json b/packages/components/psammead-inline-link/package-lock.json index 038313788d..337d74a6b1 100644 --- a/packages/components/psammead-inline-link/package-lock.json +++ b/packages/components/psammead-inline-link/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-inline-link", - "version": "1.0.1", + "version": "1.1.0", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -154,9 +154,9 @@ } }, "@bbc/psammead-styles": { - "version": "0.2.1", - "resolved": "https://registry.npmjs.org/@bbc/psammead-styles/-/psammead-styles-0.2.1.tgz", - "integrity": "sha512-FYKtW0MrCBJqbcQ7lRJ3jJPL0O9u/D8WSAcb6GTw4gMuQ011FxA1aThwLJa4LjgIBDVj4pfAbDR0CC9XmzsuXA==" + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/@bbc/psammead-styles/-/psammead-styles-1.0.0.tgz", + "integrity": "sha512-4xPQJ0IXpG9FIXvwkzkygKE9GrzHh5/DiwSCCClJlIQVSjqFMSlyz2gEsz+/l+hLCvxa729AED88Ye6Iommhsw==" }, "@bbc/psammead-test-helpers": { "version": "0.3.1", diff --git a/packages/components/psammead-inline-link/package.json b/packages/components/psammead-inline-link/package.json index 2cb46c9025..96605a48f6 100644 --- a/packages/components/psammead-inline-link/package.json +++ b/packages/components/psammead-inline-link/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-inline-link", - "version": "1.0.1", + "version": "1.1.0", "description": "React styled component for an Inline Link", "main": "dist/index.js", "repository": { @@ -23,7 +23,7 @@ }, "homepage": "https://github.com/bbc/psammead/blob/latest/packages/components/psammead-inline-link/README.md", "dependencies": { - "@bbc/psammead-styles": "^0.2.1" + "@bbc/psammead-styles": "^1.0.0" }, "devDependencies": { "@bbc/psammead-storybook-helpers": "^2.0.0", diff --git a/packages/components/psammead-inline-link/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-inline-link/src/__snapshots__/index.test.jsx.snap index 164a38d6ed..22875ea2e9 100644 --- a/packages/components/psammead-inline-link/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-inline-link/src/__snapshots__/index.test.jsx.snap @@ -2,7 +2,7 @@ exports[`InlineLink should render correctly 1`] = ` .c0 { - color: #222222; + color: #B80000; border-bottom: 1px solid #B80000; -webkit-text-decoration: none; text-decoration: none; @@ -13,14 +13,14 @@ exports[`InlineLink should render correctly 1`] = ` border-bottom: 1px solid #757575; } -.c0:focus { - color: #B80000; - border-bottom: 2px solid #B80000; -} - +.c0:focus, .c0:hover { - color: #B80000; + background-color: #B80000; border-bottom: 2px solid #B80000; + color: #FFFFFF; + margin: 0 -2px; + padding: 0 2px; + white-space: pre-wrap; } ( - {linkText} + + {linkText} +
+
+ Please note this component does not have its own typography styling + (font-size and line-height) as it is expected to be used within another + component such as paragraph or caption. For a more realistic storybook + example of this component see the Paragraph and Caption stories - this + should be removed in https://github.com/bbc/psammead/issues/733 +
)), { notes, knobs: { escapeHTML: false } }, );