From 2ed72f31892b27f07261932fa962b41ca35f1bb1 Mon Sep 17 00:00:00 2001 From: RichardPK Date: Wed, 22 Jul 2020 16:05:15 +0100 Subject: [PATCH 1/2] Updated packages and bottom of ::after --- packages/components/psammead-navigation/CHANGELOG.md | 1 + packages/components/psammead-navigation/package-lock.json | 2 +- packages/components/psammead-navigation/package.json | 2 +- .../src/__snapshots__/index.test.jsx.snap | 8 ++++---- packages/components/psammead-navigation/src/index.jsx | 2 +- 5 files changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/components/psammead-navigation/CHANGELOG.md b/packages/components/psammead-navigation/CHANGELOG.md index a46e48154a..2b1f29d47f 100644 --- a/packages/components/psammead-navigation/CHANGELOG.md +++ b/packages/components/psammead-navigation/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 6.0.14 | [PR#3613](https://github.com/bbc/psammead/pull/3613) Tweak :after styling to obscure pink bottom line | | 6.0.13 | [PR#3613](https://github.com/bbc/psammead/pull/3613) Talos - Bump Dependencies - @bbc/psammead-assets | | 6.0.12 | [PR#3604](https://github.com/bbc/psammead/pull/3604) Talos - Bump Dependencies - @bbc/gel-foundations | | 6.0.11 | [PR#3467](https://github.com/bbc/psammead/pull/3467) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-navigation/package-lock.json b/packages/components/psammead-navigation/package-lock.json index acc85814a5..1555bb0b43 100644 --- a/packages/components/psammead-navigation/package-lock.json +++ b/packages/components/psammead-navigation/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "6.0.13", + "version": "6.0.14", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-navigation/package.json b/packages/components/psammead-navigation/package.json index 917eeafcf3..3bbee7dd82 100644 --- a/packages/components/psammead-navigation/package.json +++ b/packages/components/psammead-navigation/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "6.0.13", + "version": "6.0.14", "description": "A navigation bar to use on index pages", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap index 2e95cb99fa..47a43d8fc5 100644 --- a/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap @@ -176,7 +176,7 @@ exports[`Navigation should render correctly 1`] = ` .c4::after { content: ''; position: absolute; - bottom: 0; + bottom: -1px; width: 80rem; border-bottom: 0.0625rem solid #eab3b3; z-index: -1; @@ -447,7 +447,7 @@ exports[`Navigation should render correctly when ampOpenClass prop is provided 1 .c4::after { content: ''; position: absolute; - bottom: 0; + bottom: -1px; width: 80rem; border-bottom: 0.0625rem solid #eab3b3; z-index: -1; @@ -720,7 +720,7 @@ exports[`Navigation should render correctly when isOpen is true 1`] = ` .c4::after { content: ''; position: absolute; - bottom: 0; + bottom: -1px; width: 80rem; border-bottom: 0.0625rem solid #eab3b3; z-index: -1; @@ -1025,7 +1025,7 @@ exports[`Scrollable Navigation should render correctly 1`] = ` .c5::after { content: ''; position: absolute; - bottom: 0; + bottom: -1px; width: 80rem; border-bottom: 0.0625rem solid #eab3b3; z-index: -1; diff --git a/packages/components/psammead-navigation/src/index.jsx b/packages/components/psammead-navigation/src/index.jsx index 959e60633e..daa32d99c4 100644 --- a/packages/components/psammead-navigation/src/index.jsx +++ b/packages/components/psammead-navigation/src/index.jsx @@ -102,7 +102,7 @@ const StyledListItem = styled.li` &::after { content: ''; position: absolute; - bottom: 0; + bottom: -1px; width: ${GEL_GROUP_5_SCREEN_WIDTH_MIN}; border-bottom: 0.0625rem solid ${BORDER_COLOR}; z-index: -1; From ab43ab9d370adcfd7f4506ade4d930cbc0bbb87a Mon Sep 17 00:00:00 2001 From: RichardPK Date: Wed, 22 Jul 2020 16:12:52 +0100 Subject: [PATCH 2/2] updated package v --- packages/components/psammead-navigation/package-lock.json | 2 +- packages/components/psammead-navigation/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/components/psammead-navigation/package-lock.json b/packages/components/psammead-navigation/package-lock.json index 8ddacb45aa..ba4e492983 100644 --- a/packages/components/psammead-navigation/package-lock.json +++ b/packages/components/psammead-navigation/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "6.0.14", + "version": "6.0.15", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-navigation/package.json b/packages/components/psammead-navigation/package.json index 28854dbc4e..e88f0f80d2 100644 --- a/packages/components/psammead-navigation/package.json +++ b/packages/components/psammead-navigation/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "6.0.14", + "version": "6.0.15", "description": "A navigation bar to use on index pages", "main": "dist/index.js", "module": "esm/index.js",