From 16cbc1115b845454d0c672be5c2aaabf12440cb0 Mon Sep 17 00:00:00 2001 From: sadickisaac Date: Fri, 11 Oct 2019 12:24:39 +0300 Subject: [PATCH 1/5] Spread extra props --- .../psammead-brand/package-lock.json | 2 +- .../components/psammead-brand/package.json | 2 +- .../components/psammead-brand/src/index.jsx | 2 ++ .../psammead-brand/src/index.test.jsx | 20 ++++++++++++++ .../psammead-navigation/package-lock.json | 2 +- .../psammead-navigation/package.json | 2 +- .../src/__snapshots__/index.test.jsx.snap | 8 +++--- .../psammead-navigation/src/index.jsx | 10 +++---- .../psammead-navigation/src/index.test.jsx | 23 ++++++++++++++++ .../psammead-section-label/package-lock.json | 2 +- .../psammead-section-label/package.json | 2 +- .../src/__snapshots__/index.test.jsx.snap | 15 ----------- .../psammead-section-label/src/index.jsx | 6 ++--- .../psammead-section-label/src/index.test.jsx | 22 ++++++++++++++++ .../components/psammead-story-promo/README.md | 8 +----- .../psammead-story-promo/package-lock.json | 2 +- .../psammead-story-promo/package.json | 2 +- .../src/__snapshots__/index.test.jsx.snap | 1 - .../psammead-story-promo/src/index.jsx | 6 ++--- .../psammead-story-promo/src/index.test.jsx | 26 +++---------------- 20 files changed, 91 insertions(+), 72 deletions(-) diff --git a/packages/components/psammead-brand/package-lock.json b/packages/components/psammead-brand/package-lock.json index dc445da009..23db292e61 100644 --- a/packages/components/psammead-brand/package-lock.json +++ b/packages/components/psammead-brand/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-brand", - "version": "5.0.5", + "version": "5.0.6", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-brand/package.json b/packages/components/psammead-brand/package.json index b42517e27a..2e074767c7 100644 --- a/packages/components/psammead-brand/package.json +++ b/packages/components/psammead-brand/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-brand", - "version": "5.0.5", + "version": "5.0.6", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-brand/src/index.jsx b/packages/components/psammead-brand/src/index.jsx index ead0408b37..7698bb38b8 100644 --- a/packages/components/psammead-brand/src/index.jsx +++ b/packages/components/psammead-brand/src/index.jsx @@ -174,6 +174,7 @@ const Brand = props => { borderBottom, backgroundColour, logoColour, + ...rest } = props; return ( @@ -183,6 +184,7 @@ const Brand = props => { borderBottom={borderBottom} backgroundColour={backgroundColour} logoColour={logoColour} + {...rest} > {url ? ( diff --git a/packages/components/psammead-brand/src/index.test.jsx b/packages/components/psammead-brand/src/index.test.jsx index 900849cfea..b5dec9c900 100644 --- a/packages/components/psammead-brand/src/index.test.jsx +++ b/packages/components/psammead-brand/src/index.test.jsx @@ -112,5 +112,25 @@ describe('Brand', () => { expect(container.querySelector('span').getAttribute('role')).toBeNull(); }); + + it('should add extra props passed to the component', () => { + const { container } = render( + , + ); + + expect(container.querySelector('div').getAttribute('data-brand')).toEqual( + 'header', + ); + }); }); }); diff --git a/packages/components/psammead-navigation/package-lock.json b/packages/components/psammead-navigation/package-lock.json index 764c24984c..f7353a999f 100644 --- a/packages/components/psammead-navigation/package-lock.json +++ b/packages/components/psammead-navigation/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "2.3.6", + "version": "2.3.7", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-navigation/package.json b/packages/components/psammead-navigation/package.json index a58a04f12c..dd54e9f8b4 100644 --- a/packages/components/psammead-navigation/package.json +++ b/packages/components/psammead-navigation/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "2.3.6", + "version": "2.3.7", "description": "A navigation bar to use on index pages", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap index 630400ee96..bd4ef41dfe 100644 --- a/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap @@ -251,7 +251,7 @@ exports[`Navigation should render correctly 1`] = ` > Egwuregwu @@ -286,7 +286,7 @@ exports[`Navigation should render correctly 1`] = ` > Ihe nkiri @@ -298,7 +298,7 @@ exports[`Navigation should render correctly 1`] = ` > Nke ka ewuewu diff --git a/packages/components/psammead-navigation/src/index.jsx b/packages/components/psammead-navigation/src/index.jsx index ace62170b8..0a24a65973 100644 --- a/packages/components/psammead-navigation/src/index.jsx +++ b/packages/components/psammead-navigation/src/index.jsx @@ -162,6 +162,7 @@ export const NavigationLi = ({ currentPageText, active, service, + ...props }) => ( {active && currentPageText ? ( @@ -170,19 +171,14 @@ export const NavigationLi = ({ script={script} currentLink="true" service={service} - data-navigation={`${link}_${url}`} + {...props} > {link} ) : ( - + {link} )} diff --git a/packages/components/psammead-navigation/src/index.test.jsx b/packages/components/psammead-navigation/src/index.test.jsx index 1c013c5c95..720d01fcb4 100644 --- a/packages/components/psammead-navigation/src/index.test.jsx +++ b/packages/components/psammead-navigation/src/index.test.jsx @@ -1,5 +1,6 @@ import React from 'react'; import { shouldMatchSnapshot } from '@bbc/psammead-test-helpers'; +import { render } from '@testing-library/react'; import { latin } from '@bbc/gel-foundations/scripts'; import Navigation, { NavigationUl, NavigationLi } from './index'; import igboNavData from '../testHelpers/igbo'; @@ -21,6 +22,7 @@ describe('Navigation', () => { active={active} currentPageText="Current page" service="news" + data-naviation="test_navigation" > {title} @@ -30,3 +32,24 @@ describe('Navigation', () => { , ); }); + +describe('Assertions', () => { + it('should add extra props passed to the NavigationLi link', () => { + const { container } = render( + + Testing exta props + , + ); + expect( + container.querySelector('a').getAttribute('data-navigation'), + ).toEqual('test_navigation'); + }); +}); diff --git a/packages/components/psammead-section-label/package-lock.json b/packages/components/psammead-section-label/package-lock.json index ea7147f723..22b232c011 100644 --- a/packages/components/psammead-section-label/package-lock.json +++ b/packages/components/psammead-section-label/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-section-label", - "version": "2.3.18", + "version": "2.3.19", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-section-label/package.json b/packages/components/psammead-section-label/package.json index d0e1a07fcd..f24871f26f 100644 --- a/packages/components/psammead-section-label/package.json +++ b/packages/components/psammead-section-label/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-section-label", - "version": "2.3.18", + "version": "2.3.19", "description": "React styled component for a section label", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-section-label/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-section-label/src/__snapshots__/index.test.jsx.snap index 722834a27e..63cc310931 100644 --- a/packages/components/psammead-section-label/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-section-label/src/__snapshots__/index.test.jsx.snap @@ -111,7 +111,6 @@ exports[`SectionLabel When hideSectionHeader is true should add styling to hide

( - + {bar && } {linkText && href ? ( diff --git a/packages/components/psammead-section-label/src/index.test.jsx b/packages/components/psammead-section-label/src/index.test.jsx index aa13daf853..367eea7b69 100644 --- a/packages/components/psammead-section-label/src/index.test.jsx +++ b/packages/components/psammead-section-label/src/index.test.jsx @@ -1,5 +1,6 @@ import React from 'react'; import { shouldMatchSnapshot } from '@bbc/psammead-test-helpers'; +import { render } from '@testing-library/react'; import { latin, arabic } from '@bbc/gel-foundations/scripts'; import SectionLabel from './index'; @@ -214,4 +215,25 @@ describe('SectionLabel', () => { , ); }); + + describe('Assertions', () => { + it('should add extra props passed to the component', () => { + const { container } = render( + + This is the text in a SectionLabel + , + ); + + expect( + container.querySelector('div').getAttribute('data-section-divider'), + ).toEqual('section_name'); + }); + }); }); diff --git a/packages/components/psammead-story-promo/README.md b/packages/components/psammead-story-promo/README.md index 4cbac09cd4..9d564c5a5d 100644 --- a/packages/components/psammead-story-promo/README.md +++ b/packages/components/psammead-story-promo/README.md @@ -25,7 +25,6 @@ The `StoryPromo` component is designed to be used on 'index' pages, which are pa | info | node | Yes | N/A | `

Title

` | | mediaIndicator | node | No | null | `` | | topStory | boolean | No | false | true | -| sectionName| string | No | `null` | `'story-promo-section-name'` | ## Headline Props @@ -203,12 +202,7 @@ const Info = ({ isLive, alsoItems }) => ( ); -; +; ``` ### When to use this component diff --git a/packages/components/psammead-story-promo/package-lock.json b/packages/components/psammead-story-promo/package-lock.json index 8bbe6a1a94..ad3ebd290d 100644 --- a/packages/components/psammead-story-promo/package-lock.json +++ b/packages/components/psammead-story-promo/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "2.8.0-alpha.1", + "version": "2.8.0-alpha.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-story-promo/package.json b/packages/components/psammead-story-promo/package.json index 3856619715..66a8212935 100644 --- a/packages/components/psammead-story-promo/package.json +++ b/packages/components/psammead-story-promo/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "2.8.0-alpha.1", + "version": "2.8.0-alpha.2", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-story-promo/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-story-promo/src/__snapshots__/index.test.jsx.snap index e2bfd009ee..882a036103 100644 --- a/packages/components/psammead-story-promo/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-story-promo/src/__snapshots__/index.test.jsx.snap @@ -1622,7 +1622,6 @@ exports[`StoryPromo should render correctly 1`] = `
( - +const StoryPromo = ({ image, info, mediaIndicator, topStory, ...props }) => ( + {image} @@ -332,13 +332,11 @@ StoryPromo.propTypes = { info: node.isRequired, mediaIndicator: node, topStory: bool, - sectionName: string, }; StoryPromo.defaultProps = { mediaIndicator: null, topStory: false, - sectionName: null, }; export default StoryPromo; diff --git a/packages/components/psammead-story-promo/src/index.test.jsx b/packages/components/psammead-story-promo/src/index.test.jsx index bac8747c81..ac0556d6d0 100644 --- a/packages/components/psammead-story-promo/src/index.test.jsx +++ b/packages/components/psammead-story-promo/src/index.test.jsx @@ -53,11 +53,7 @@ const mediaInfo = ( describe('StoryPromo', () => { shouldMatchSnapshot( 'should render correctly', - , + , ); shouldMatchSnapshot( 'should render Live promo correctly', @@ -137,32 +133,18 @@ describe('assertions', () => { expect(image.getAttribute('alt')).toEqual('Alt text'); }); - it('should have data-story-promo attribute when sectionName is provided', () => { - const { container } = render( - , - ); - - expect( - container.querySelector('div').getAttribute('data-story-promo'), - ).toEqual('section-name'); - }); - - it('should not have data-story-promo attribute when sectionName is not provided', () => { + it('should add extra props passed to the component', () => { const { container } = render( , ); expect( container.querySelector('div').getAttribute('data-story-promo'), - ).toBeNull(); + ).toEqual('story_promo'); }); }); From b73c0fad0051ba03d9df31d0906992af8c9242f2 Mon Sep 17 00:00:00 2001 From: sadickisaac Date: Fri, 11 Oct 2019 12:37:46 +0300 Subject: [PATCH 2/5] Update changelogs Updates changelogs for psammead-brand, psammead-navigation, psammead-section-label, psammead-story-promo --- packages/components/psammead-brand/CHANGELOG.md | 1 + packages/components/psammead-navigation/CHANGELOG.md | 1 + packages/components/psammead-section-label/CHANGELOG.md | 1 + packages/components/psammead-story-promo/CHANGELOG.md | 1 + 4 files changed, 4 insertions(+) diff --git a/packages/components/psammead-brand/CHANGELOG.md b/packages/components/psammead-brand/CHANGELOG.md index bb1183a257..25e118a616 100644 --- a/packages/components/psammead-brand/CHANGELOG.md +++ b/packages/components/psammead-brand/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------- | ----------- | +| 5.0.6 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 5.0.5 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | | 5.0.4 | [PR#2273](https://github.com/bbc/psammead/pull/2273) Talos - Bump Dependencies - @bbc/psammead-styles | | 5.0.3 | [PR#2251](https://github.com/bbc/psammead/pull/2251) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-navigation/CHANGELOG.md b/packages/components/psammead-navigation/CHANGELOG.md index b05dc8fbde..9b86c2e86a 100644 --- a/packages/components/psammead-navigation/CHANGELOG.md +++ b/packages/components/psammead-navigation/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 2.3.7 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 2.3.6 | [PR#2343](https://github.com/bbc/psammead/pull/2343) Add `data-navigation` data attribute to navigation links | | 2.3.5 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.3.4 | [PR#2273](https://github.com/bbc/psammead/pull/2273) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-section-label/CHANGELOG.md b/packages/components/psammead-section-label/CHANGELOG.md index afb21569cb..324d0988fa 100644 --- a/packages/components/psammead-section-label/CHANGELOG.md +++ b/packages/components/psammead-section-label/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 2.3.19 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 2.3.18 | [PR#2353](https://github.com/bbc/psammead/pull/2353) Use `labelId` prop to set `data-section-divider` for event tracking | | 2.3.17 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.3.16 | [PR#2273](https://github.com/bbc/psammead/pull/2273) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-story-promo/CHANGELOG.md b/packages/components/psammead-story-promo/CHANGELOG.md index c443815d7c..30e1e3707a 100644 --- a/packages/components/psammead-story-promo/CHANGELOG.md +++ b/packages/components/psammead-story-promo/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------- | ----------- | +| 2.8.0-alpha.2 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 2.8.0-alpha.1 | [PR#2354](https://github.com/bbc/psammead/pull/2354) Add `sectionName` prop to set `data-story-promo` for event tracking | | 2.8.0-alpha.0 | [PR#2296](https://github.com/bbc/psammead/pull/2296) Change Story Promo design 1080+px | | 2.7.18 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | From 7eb7c4e70139b384de877a0043de70bd22844531 Mon Sep 17 00:00:00 2001 From: sadickisaac Date: Fri, 11 Oct 2019 17:02:30 +0300 Subject: [PATCH 3/5] Bump version --- packages/components/psammead-navigation/CHANGELOG.md | 2 +- packages/components/psammead-navigation/package-lock.json | 2 +- packages/components/psammead-navigation/package.json | 2 +- packages/components/psammead-section-label/CHANGELOG.md | 2 +- packages/components/psammead-section-label/package-lock.json | 2 +- packages/components/psammead-section-label/package.json | 2 +- packages/components/psammead-story-promo/CHANGELOG.md | 2 +- packages/components/psammead-story-promo/package-lock.json | 2 +- packages/components/psammead-story-promo/package.json | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/components/psammead-navigation/CHANGELOG.md b/packages/components/psammead-navigation/CHANGELOG.md index 9b86c2e86a..fc64efef27 100644 --- a/packages/components/psammead-navigation/CHANGELOG.md +++ b/packages/components/psammead-navigation/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 2.3.7 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | +| 2.4.0 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 2.3.6 | [PR#2343](https://github.com/bbc/psammead/pull/2343) Add `data-navigation` data attribute to navigation links | | 2.3.5 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.3.4 | [PR#2273](https://github.com/bbc/psammead/pull/2273) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-navigation/package-lock.json b/packages/components/psammead-navigation/package-lock.json index f7353a999f..e8680118b6 100644 --- a/packages/components/psammead-navigation/package-lock.json +++ b/packages/components/psammead-navigation/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "2.3.7", + "version": "2.4.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-navigation/package.json b/packages/components/psammead-navigation/package.json index dd54e9f8b4..85355096ed 100644 --- a/packages/components/psammead-navigation/package.json +++ b/packages/components/psammead-navigation/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "2.3.7", + "version": "2.4.0", "description": "A navigation bar to use on index pages", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-section-label/CHANGELOG.md b/packages/components/psammead-section-label/CHANGELOG.md index 324d0988fa..bb66fc288f 100644 --- a/packages/components/psammead-section-label/CHANGELOG.md +++ b/packages/components/psammead-section-label/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 2.3.19 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | +| 2.4.0 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 2.3.18 | [PR#2353](https://github.com/bbc/psammead/pull/2353) Use `labelId` prop to set `data-section-divider` for event tracking | | 2.3.17 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.3.16 | [PR#2273](https://github.com/bbc/psammead/pull/2273) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-section-label/package-lock.json b/packages/components/psammead-section-label/package-lock.json index 22b232c011..93649bed20 100644 --- a/packages/components/psammead-section-label/package-lock.json +++ b/packages/components/psammead-section-label/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-section-label", - "version": "2.3.19", + "version": "2.4.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-section-label/package.json b/packages/components/psammead-section-label/package.json index f24871f26f..451c1d6d95 100644 --- a/packages/components/psammead-section-label/package.json +++ b/packages/components/psammead-section-label/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-section-label", - "version": "2.3.19", + "version": "2.4.0", "description": "React styled component for a section label", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-story-promo/CHANGELOG.md b/packages/components/psammead-story-promo/CHANGELOG.md index 30e1e3707a..ffec7c8c22 100644 --- a/packages/components/psammead-story-promo/CHANGELOG.md +++ b/packages/components/psammead-story-promo/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | | ------- | ----------- | -| 2.8.0-alpha.2 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | +| 2.9.0-alpha.0 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 2.8.0-alpha.1 | [PR#2354](https://github.com/bbc/psammead/pull/2354) Add `sectionName` prop to set `data-story-promo` for event tracking | | 2.8.0-alpha.0 | [PR#2296](https://github.com/bbc/psammead/pull/2296) Change Story Promo design 1080+px | | 2.7.18 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-story-promo/package-lock.json b/packages/components/psammead-story-promo/package-lock.json index ad3ebd290d..c15b86365e 100644 --- a/packages/components/psammead-story-promo/package-lock.json +++ b/packages/components/psammead-story-promo/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "2.8.0-alpha.2", + "version": "2.9.0-alpha.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-story-promo/package.json b/packages/components/psammead-story-promo/package.json index 66a8212935..6b3725c436 100644 --- a/packages/components/psammead-story-promo/package.json +++ b/packages/components/psammead-story-promo/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "2.8.0-alpha.2", + "version": "2.9.0-alpha.0", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, From 527d91eab27bf7ab97bdd62b6c995223180bfce8 Mon Sep 17 00:00:00 2001 From: Denis Hernandez Date: Mon, 14 Oct 2019 10:42:12 +0100 Subject: [PATCH 4/5] Fix typo --- .../src/__snapshots__/index.test.jsx.snap | 8 ++++---- .../components/psammead-navigation/src/index.test.jsx | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap index bd4ef41dfe..9a733a9e83 100644 --- a/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-navigation/src/__snapshots__/index.test.jsx.snap @@ -251,7 +251,7 @@ exports[`Navigation should render correctly 1`] = ` > Egwuregwu @@ -286,7 +286,7 @@ exports[`Navigation should render correctly 1`] = ` > Ihe nkiri @@ -298,7 +298,7 @@ exports[`Navigation should render correctly 1`] = ` > Nke ka ewuewu diff --git a/packages/components/psammead-navigation/src/index.test.jsx b/packages/components/psammead-navigation/src/index.test.jsx index 720d01fcb4..cd67c5b2cf 100644 --- a/packages/components/psammead-navigation/src/index.test.jsx +++ b/packages/components/psammead-navigation/src/index.test.jsx @@ -22,7 +22,7 @@ describe('Navigation', () => { active={active} currentPageText="Current page" service="news" - data-naviation="test_navigation" + data-navigation="test_navigation" > {title} From 10e22a6a63106042f9cbfb6afbfda829895048ce Mon Sep 17 00:00:00 2001 From: Denis Hernandez Date: Tue, 15 Oct 2019 15:25:17 +0100 Subject: [PATCH 5/5] Bump to major version --- packages/components/psammead-navigation/CHANGELOG.md | 2 +- packages/components/psammead-navigation/package-lock.json | 2 +- packages/components/psammead-navigation/package.json | 2 +- packages/components/psammead-section-label/CHANGELOG.md | 2 +- packages/components/psammead-section-label/package-lock.json | 2 +- packages/components/psammead-section-label/package.json | 2 +- packages/components/psammead-story-promo/CHANGELOG.md | 2 +- packages/components/psammead-story-promo/package-lock.json | 2 +- packages/components/psammead-story-promo/package.json | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/components/psammead-navigation/CHANGELOG.md b/packages/components/psammead-navigation/CHANGELOG.md index fc64efef27..fca80dc39d 100644 --- a/packages/components/psammead-navigation/CHANGELOG.md +++ b/packages/components/psammead-navigation/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 2.4.0 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | +| 3.0.0 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 2.3.6 | [PR#2343](https://github.com/bbc/psammead/pull/2343) Add `data-navigation` data attribute to navigation links | | 2.3.5 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.3.4 | [PR#2273](https://github.com/bbc/psammead/pull/2273) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-navigation/package-lock.json b/packages/components/psammead-navigation/package-lock.json index e8680118b6..8785a7c949 100644 --- a/packages/components/psammead-navigation/package-lock.json +++ b/packages/components/psammead-navigation/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "2.4.0", + "version": "3.0.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-navigation/package.json b/packages/components/psammead-navigation/package.json index 85355096ed..044224fc97 100644 --- a/packages/components/psammead-navigation/package.json +++ b/packages/components/psammead-navigation/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "2.4.0", + "version": "3.0.0", "description": "A navigation bar to use on index pages", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-section-label/CHANGELOG.md b/packages/components/psammead-section-label/CHANGELOG.md index bb66fc288f..145a319c30 100644 --- a/packages/components/psammead-section-label/CHANGELOG.md +++ b/packages/components/psammead-section-label/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 2.4.0 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | +| 3.0.0 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 2.3.18 | [PR#2353](https://github.com/bbc/psammead/pull/2353) Use `labelId` prop to set `data-section-divider` for event tracking | | 2.3.17 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.3.16 | [PR#2273](https://github.com/bbc/psammead/pull/2273) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-section-label/package-lock.json b/packages/components/psammead-section-label/package-lock.json index 93649bed20..155724b884 100644 --- a/packages/components/psammead-section-label/package-lock.json +++ b/packages/components/psammead-section-label/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-section-label", - "version": "2.4.0", + "version": "3.0.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-section-label/package.json b/packages/components/psammead-section-label/package.json index 451c1d6d95..2c044d1f78 100644 --- a/packages/components/psammead-section-label/package.json +++ b/packages/components/psammead-section-label/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-section-label", - "version": "2.4.0", + "version": "3.0.0", "description": "React styled component for a section label", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-story-promo/CHANGELOG.md b/packages/components/psammead-story-promo/CHANGELOG.md index ffec7c8c22..7c6bb6c3d0 100644 --- a/packages/components/psammead-story-promo/CHANGELOG.md +++ b/packages/components/psammead-story-promo/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | | ------- | ----------- | -| 2.9.0-alpha.0 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | +| 3.0.0-alpha.0 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | 2.8.0-alpha.1 | [PR#2354](https://github.com/bbc/psammead/pull/2354) Add `sectionName` prop to set `data-story-promo` for event tracking | | 2.8.0-alpha.0 | [PR#2296](https://github.com/bbc/psammead/pull/2296) Change Story Promo design 1080+px | | 2.7.18 | [PR#2289](https://github.com/bbc/psammead/pull/2289) Talos - Bump Dependencies - @bbc/psammead-styles | diff --git a/packages/components/psammead-story-promo/package-lock.json b/packages/components/psammead-story-promo/package-lock.json index c15b86365e..a232b5eab8 100644 --- a/packages/components/psammead-story-promo/package-lock.json +++ b/packages/components/psammead-story-promo/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "2.9.0-alpha.0", + "version": "3.0.0-alpha.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-story-promo/package.json b/packages/components/psammead-story-promo/package.json index 6b3725c436..d92437ef5e 100644 --- a/packages/components/psammead-story-promo/package.json +++ b/packages/components/psammead-story-promo/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "2.9.0-alpha.0", + "version": "3.0.0-alpha.0", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false,