From 0ec9490d1ace5c2ba326ca02d114f6177f82826c Mon Sep 17 00:00:00 2001 From: Einstein Date: Thu, 19 Sep 2019 17:05:19 +0300 Subject: [PATCH 1/4] Add stories in storybook for media icons in psammead-assets --- .../psammead-assets/src/svgs.stories.jsx | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/packages/utilities/psammead-assets/src/svgs.stories.jsx b/packages/utilities/psammead-assets/src/svgs.stories.jsx index 24e6ce12ac..073db0a628 100644 --- a/packages/utilities/psammead-assets/src/svgs.stories.jsx +++ b/packages/utilities/psammead-assets/src/svgs.stories.jsx @@ -4,7 +4,9 @@ import { node, number, shape } from 'prop-types'; import { storiesOf } from '@storybook/react'; import { number as numberKnob, withKnobs } from '@storybook/addon-knobs'; import notes from '../README.md'; -import * as svgs from './svgs'; +import * as allSvgs from './svgs'; + +const { mediaIcons, ...svgs } = allSvgs; // `currentColor` has been used to address high contrast mode in Firefox. const Svg = styled.svg` @@ -58,10 +60,11 @@ getSVG.propTypes = { height: number, }; -const stories = storiesOf('Utilities|SVGs', module).addDecorator(withKnobs); - +const stories = storiesOf('Utilities|SVGs/Brand Svgs', module).addDecorator( + withKnobs, +); Object.keys(svgs) - .filter(svgName => svgName !== 'BBC_BLOCKS' && svgName !== 'mediaIcons') + .filter(svgName => svgName !== 'BBC_BLOCKS') .forEach(svgName => { stories.add( svgName, @@ -72,3 +75,12 @@ Object.keys(svgs) { notes }, ); }); + +const mediaIconStories = storiesOf( + 'Utilities|SVGs/MediaIcon Svgs', + module, +).addDecorator(withKnobs); + +Object.keys(mediaIcons).forEach(iconName => { + mediaIconStories.add(iconName, () => mediaIcons[iconName]); +}); From 1bc231cd2598574b57e3619d6ee2933207784242 Mon Sep 17 00:00:00 2001 From: Einstein Date: Thu, 19 Sep 2019 17:25:15 +0300 Subject: [PATCH 2/4] Bump version and update changelog --- packages/utilities/psammead-assets/CHANGELOG.md | 1 + packages/utilities/psammead-assets/package-lock.json | 2 +- packages/utilities/psammead-assets/package.json | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/utilities/psammead-assets/CHANGELOG.md b/packages/utilities/psammead-assets/CHANGELOG.md index e6a6740a2a..1ca6fb2b56 100644 --- a/packages/utilities/psammead-assets/CHANGELOG.md +++ b/packages/utilities/psammead-assets/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 2.3.1 | [PR#2189](https://github.com/bbc/psammead/pull/2189) Add storybook stories for media icons in psammead-assets | | 2.3.0 | [PR#2115](https://github.com/bbc/psammead/pull/2115) Added media icons SVGs | | 2.2.4 | [PR#1942](https://github.com/bbc/psammead/pull/1942) Talos - Bump React to 16.9.0 | | 2.2.3 | [PR#1847](https://github.com/bbc/psammead/pull/1847) Fixed Telugu typos | diff --git a/packages/utilities/psammead-assets/package-lock.json b/packages/utilities/psammead-assets/package-lock.json index 2e167b7d27..973e3e5186 100644 --- a/packages/utilities/psammead-assets/package-lock.json +++ b/packages/utilities/psammead-assets/package-lock.json @@ -1,5 +1,5 @@ { "name": "@bbc/psammead-assets", - "version": "2.3.0", + "version": "2.3.1", "lockfileVersion": 1 } diff --git a/packages/utilities/psammead-assets/package.json b/packages/utilities/psammead-assets/package.json index af3915b1fa..6d9f9a9f22 100644 --- a/packages/utilities/psammead-assets/package.json +++ b/packages/utilities/psammead-assets/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-assets", - "version": "2.3.0", + "version": "2.3.1", "sideEffects": false, "description": "A collection of common assets that are likely to be required by many Psammead components or users, such as SVGs or small scripts.", "repository": { From 2d5a79c5450213b870cec9bfd23bfcaa7ba59702 Mon Sep 17 00:00:00 2001 From: Einstein Date: Fri, 20 Sep 2019 15:51:45 +0300 Subject: [PATCH 3/4] add notes --- packages/utilities/psammead-assets/src/svgs.stories.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/utilities/psammead-assets/src/svgs.stories.jsx b/packages/utilities/psammead-assets/src/svgs.stories.jsx index 073db0a628..f2b304cf5e 100644 --- a/packages/utilities/psammead-assets/src/svgs.stories.jsx +++ b/packages/utilities/psammead-assets/src/svgs.stories.jsx @@ -82,5 +82,5 @@ const mediaIconStories = storiesOf( ).addDecorator(withKnobs); Object.keys(mediaIcons).forEach(iconName => { - mediaIconStories.add(iconName, () => mediaIcons[iconName]); + mediaIconStories.add(iconName, () => mediaIcons[iconName], { notes }); }); From eccb6e4a79c7ae468048d523fa13d56bb20b6ed8 Mon Sep 17 00:00:00 2001 From: Einstein Njoroge Date: Mon, 23 Sep 2019 13:21:21 +0300 Subject: [PATCH 4/4] Update packages/utilities/psammead-assets/src/svgs.stories.jsx Co-Authored-By: Denis Hernandez <46446236+DenisHdz@users.noreply.github.com> --- packages/utilities/psammead-assets/src/svgs.stories.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/utilities/psammead-assets/src/svgs.stories.jsx b/packages/utilities/psammead-assets/src/svgs.stories.jsx index f2b304cf5e..e2e00e556a 100644 --- a/packages/utilities/psammead-assets/src/svgs.stories.jsx +++ b/packages/utilities/psammead-assets/src/svgs.stories.jsx @@ -77,7 +77,7 @@ Object.keys(svgs) }); const mediaIconStories = storiesOf( - 'Utilities|SVGs/MediaIcon Svgs', + 'Utilities|SVGs/MediaIcons Svgs', module, ).addDecorator(withKnobs);