Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Use visually hidden text instead of aria-label for navigation menu button. #2950

Closed
1 task
tochwill opened this issue Jan 17, 2020 · 0 comments · Fixed by #2951
Closed
1 task

Use visually hidden text instead of aria-label for navigation menu button. #2950

tochwill opened this issue Jan 17, 2020 · 0 comments · Fixed by #2951
Assignees
Labels
bug Something isn't working ws-home Tasks for the WS Home Team

Comments

@tochwill
Copy link
Contributor

Describe the bug
The BBC a11y check on CI is failing with the following error:

 * Forms: Labelling form controls: Fields must have labels or titles
    - Button has no text: //div[@id='root']/header/nav/div/div[1]/button

This is because the button contains no text, and relies instead on an aria-label. We can use the VisuallyHiddenText component instead, which will pass the a11y acceptance criteria.

Ensure that the correct screen reader behaviour is still present after this change is made.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behaviour
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Testing notes

  • This bug fix is expected to need manual testing.

Additional context
Add any other context about the problem here.

@tochwill tochwill added bug Something isn't working ws-home Tasks for the WS Home Team labels Jan 17, 2020
@tochwill tochwill self-assigned this Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant