You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Describe the bug
The BBC a11y check on CI is failing with the following error:
* Forms: Labelling form controls: Fields must have labels or titles
- Button has no text: //div[@id='root']/header/nav/div/div[1]/button
This is because the button contains no text, and relies instead on an aria-label. We can use the VisuallyHiddenText component instead, which will pass the a11y acceptance criteria.
Ensure that the correct screen reader behaviour is still present after this change is made.
To Reproduce
Steps to reproduce the behaviour:
Go to '...'
Click on '....'
Scroll down to '....'
See error
Expected behaviour
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]
Smartphone (please complete the following information):
Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]
Testing notes
This bug fix is expected to need manual testing.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
Describe the bug
The BBC a11y check on CI is failing with the following error:
This is because the button contains no text, and relies instead on an
aria-label
. We can use theVisuallyHiddenText
component instead, which will pass the a11y acceptance criteria.Ensure that the correct screen reader behaviour is still present after this change is made.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Testing notes
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: