Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Use new grid detector #1364

Closed
ghost opened this issue Jul 18, 2019 · 0 comments · Fixed by #1408
Closed

Use new grid detector #1364

ghost opened this issue Jul 18, 2019 · 0 comments · Fixed by #1408
Assignees
@DenisHdz
Labels
ws-home Tasks for the WS Home Team

Comments

@ghost
Copy link

ghost commented Jul 18, 2019 •
edited by andrew-nowak
Loading

Is your feature request related to a problem? Please describe.
Following #1234 we now have a stricter way of detecting grid support. On some of our components we are still relying on @supports ( display: grid )

Describe the solution you'd like
Use the new grid detection from @bbc/psammead-styles/detection on psammead-sitewide-links and psammead-story-promo and others you might come across.

Describe alternatives you've considered

Testing notes
[Tester to complete]

Dev insight: Regression on updated components

Additional context
Add any other context or screenshots about the feature request here.
@ghost ghost added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team labels Jul 18, 2019
@j-pendlebury j-pendlebury removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jul 22, 2019
@DenisHdz DenisHdz self-assigned this Jul 22, 2019
@DenisHdz DenisHdz mentioned this issue Jul 22, 2019
Merged
3 tasks
@andrew-nowak andrew-nowak mentioned this issue Jul 23, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DenisHdz DenisHdz

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new custom grid detector BBC-archive/psammead
2 participants
@j-pendlebury @DenisHdz