From 831e93380577a513535267ba52771848cf1ea18e Mon Sep 17 00:00:00 2001 From: Denis Hernandez Date: Thu, 4 Jul 2019 15:28:32 +0100 Subject: [PATCH 01/13] Make media indicator shorter under 400px --- .../psammead-media-indicator/CHANGELOG.md | 1 + .../package-lock.json | 96 +++++++++---------- .../psammead-media-indicator/package.json | 12 +-- .../src/__snapshots__/index.test.jsx.snap | 30 ++++++ .../psammead-media-indicator/src/index.jsx | 25 ++++- 5 files changed, 102 insertions(+), 62 deletions(-) diff --git a/packages/components/psammead-media-indicator/CHANGELOG.md b/packages/components/psammead-media-indicator/CHANGELOG.md index 315855da01..13928b0a8e 100644 --- a/packages/components/psammead-media-indicator/CHANGELOG.md +++ b/packages/components/psammead-media-indicator/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------- | ----------- | +| 1.0.4 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Add `topStory` prop, change padding <400px and bump dependencies | | 1.0.3 | [PR#713](https://github.com/bbc/psammead/pull/713) Update `styled-components` to 4.3.2 | | 1.0.2 | [PR#722](https://github.com/bbc/psammead/pull/722) Fix hover cap on older browsers | | 1.0.1 | [PR#677](https://github.com/bbc/psammead/pull/677) Use `@bbc/gel-foundations@3.0.0` | diff --git a/packages/components/psammead-media-indicator/package-lock.json b/packages/components/psammead-media-indicator/package-lock.json index b3920077d1..30066bf411 100644 --- a/packages/components/psammead-media-indicator/package-lock.json +++ b/packages/components/psammead-media-indicator/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-media-indicator", - "version": "1.0.3", + "version": "1.0.4", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -138,67 +138,39 @@ } }, "@bbc/gel-foundations": { - "version": "3.0.0", - "resolved": "https://registry.npmjs.org/@bbc/gel-foundations/-/gel-foundations-3.0.0.tgz", - "integrity": "sha512-dHVZ+ig1P/crQtvAOP0bB0PAuuqT2R8hs15pZDsJsO1wvPtbvEe2TO6AxXUIODk9TZgod2j+9K6TB4WV/I2LDw==" + "version": "3.0.1", + "resolved": "https://registry.npmjs.org/@bbc/gel-foundations/-/gel-foundations-3.0.1.tgz", + "integrity": "sha512-Ak0/+lPuCq8aPbOlzxj6/ayr5SmwNZo49dcnK3NHNugH5TEKmt+gjQhsZG6PSxpCEPk5OXhviPiNUEVr4wVObA==" }, "@bbc/psammead-storybook-helpers": { - "version": "2.1.1", - "resolved": "https://registry.npmjs.org/@bbc/psammead-storybook-helpers/-/psammead-storybook-helpers-2.1.1.tgz", - "integrity": "sha512-kKpeH97+PY439LoUkTceNtgJynjRbwU9AbmNjsZ18h+alVR2PbZ2j2uYXTo6ux1DiCN3L15aLZmu4K3VordLmw==", + "version": "3.1.0", + "resolved": "https://registry.npmjs.org/@bbc/psammead-storybook-helpers/-/psammead-storybook-helpers-3.1.0.tgz", + "integrity": "sha512-mah7Mh+Gh6apbCEF+WVxCeMtxrDzck06oPYsVqUb/gaKGziJ7U0Sf8vh0VkorcZy0i1DfDWr75NKDBIf45QiMQ==", "dev": true, "requires": { - "@bbc/gel-foundations": "^1.2.0", + "@bbc/gel-foundations": "^3.0.0", "react-helmet": "^5.2.0" - }, - "dependencies": { - "@bbc/gel-foundations": { - "version": "1.2.0", - "resolved": "https://registry.npmjs.org/@bbc/gel-foundations/-/gel-foundations-1.2.0.tgz", - "integrity": "sha512-OpEJf42FSgyZRN0e9pJFm9eYmzbhfB7W7EWlrjh46fWlozyVwKA4uaTPUoGHLbXJkMOhPdpfM3gOAxbuM0FnrQ==", - "dev": true - } } }, "@bbc/psammead-styles": { - "version": "0.3.3", - "resolved": "https://registry.npmjs.org/@bbc/psammead-styles/-/psammead-styles-0.3.3.tgz", - "integrity": "sha512-9SG698tmq8o7Ja6sFQ6WwHpVEJtCbP99Z80wSnnB4ZWryfasd+EaRXtvGwGvWG2U9oA34S27syJQIh062Mkztw==" + "version": "1.1.0", + "resolved": "https://registry.npmjs.org/@bbc/psammead-styles/-/psammead-styles-1.1.0.tgz", + "integrity": "sha512-nGNN/tGYQ9Gn+W3NK/1ELHTx8F+i6kxgfNv9pPRcRAfYJH+spTseW82+etK3acbXXr29I5eucRW4XM+SMNeEwQ==" }, "@bbc/psammead-test-helpers": { - "version": "0.3.3", - "resolved": "https://registry.npmjs.org/@bbc/psammead-test-helpers/-/psammead-test-helpers-0.3.3.tgz", - "integrity": "sha512-w/ENAOLuXZ8f2l3IJ2wYKEuNVH69xn0p4YIV6qx6GpZBYdP12n5sBi1lvGZOKD9tRa3UOGN5WZzxrZLjcUCh+w==", + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/@bbc/psammead-test-helpers/-/psammead-test-helpers-1.0.0.tgz", + "integrity": "sha512-YEx7bb9eFYUw1dpkgmHcuOYQBZjhvOCPM2fUWShfgtwpcaVNuOsKEIbVng3Au//t4arAbYmRs+Upn+ygriLEfw==", "dev": true, "requires": { "jest-styled-components": "^6.3.1", - "react-test-renderer": "^16.6.3" - }, - "dependencies": { - "react-is": { - "version": "16.8.6", - "resolved": "https://registry.npmjs.org/react-is/-/react-is-16.8.6.tgz", - "integrity": "sha512-aUk3bHfZ2bRSVFFbbeVS4i+lNPZr3/WM5jT2J5omUVV1zzcs1nAaf3l51ctA5FFvCRbhrH0bdAsRRQddFJZPtA==", - "dev": true - }, - "react-test-renderer": { - "version": "16.8.6", - "resolved": "https://registry.npmjs.org/react-test-renderer/-/react-test-renderer-16.8.6.tgz", - "integrity": "sha512-H2srzU5IWYT6cZXof6AhUcx/wEyJddQ8l7cLM/F7gDXYyPr4oq+vCIxJYXVGhId1J706sqziAjuOEjyNkfgoEw==", - "dev": true, - "requires": { - "object-assign": "^4.1.1", - "prop-types": "^15.6.2", - "react-is": "^16.8.6", - "scheduler": "^0.13.6" - } - } + "react-test-renderer": "^16.8.6" } }, "@bbc/psammead-visually-hidden-text": { - "version": "0.1.12", - "resolved": "https://registry.npmjs.org/@bbc/psammead-visually-hidden-text/-/psammead-visually-hidden-text-0.1.12.tgz", - "integrity": "sha512-nTgniZ9edCscJs7xDoh/bWuoCkoa6AIoVpVH2/ekMBDG2UUgj9yGJZts0Ki89l2IlQBQOBZbE/vRzgsuVDszTg==" + "version": "1.0.1", + "resolved": "https://registry.npmjs.org/@bbc/psammead-visually-hidden-text/-/psammead-visually-hidden-text-1.0.1.tgz", + "integrity": "sha512-e281xGygQEHoO5trmddHwNouA7EhpQ+p3Iq3srVPV0ItHxEOzcKc8cmiL0xdgZPsOxauCVcyb1isaS5eF3rNBg==" }, "@emotion/is-prop-valid": { "version": "0.8.2", @@ -361,9 +333,9 @@ "dev": true }, "inherits": { - "version": "2.0.3", - "resolved": "https://registry.npmjs.org/inherits/-/inherits-2.0.3.tgz", - "integrity": "sha1-Yzwsg+PaQqUC9SRmAiSA9CCCYd4=", + "version": "2.0.4", + "resolved": "https://registry.npmjs.org/inherits/-/inherits-2.0.4.tgz", + "integrity": "sha512-k/vGaX4/Yla3WzyMCvTQOXYeIHvqOKtnqBduzTHpzpQZzAskKMhZ2K+EnBiSM9zGSoIFeMpXKxa4dYeZIQqewQ==", "dev": true }, "is-what": { @@ -373,9 +345,9 @@ "dev": true }, "jest-styled-components": { - "version": "6.3.1", - "resolved": "https://registry.npmjs.org/jest-styled-components/-/jest-styled-components-6.3.1.tgz", - "integrity": "sha512-zie3ajvJbwlbHCAq8/Bv5jdbcYCz0ZMRNNX6adL7wSRpkCVPQtiJigv1140JN1ZOJIODPn8VKrjeFCN+jlPa7w==", + "version": "6.3.3", + "resolved": "https://registry.npmjs.org/jest-styled-components/-/jest-styled-components-6.3.3.tgz", + "integrity": "sha512-RBMPZSJJSgPDTTJsuYzx5fsij/CULaqQNZOWkn8J/L++rX6P830o2vB9CXGzfQf/bVq9qGr1ZBNoivi+v6JPYg==", "dev": true, "requires": { "css": "^2.2.4" @@ -498,6 +470,26 @@ "shallowequal": "^1.0.1" } }, + "react-test-renderer": { + "version": "16.8.6", + "resolved": "https://registry.npmjs.org/react-test-renderer/-/react-test-renderer-16.8.6.tgz", + "integrity": "sha512-H2srzU5IWYT6cZXof6AhUcx/wEyJddQ8l7cLM/F7gDXYyPr4oq+vCIxJYXVGhId1J706sqziAjuOEjyNkfgoEw==", + "dev": true, + "requires": { + "object-assign": "^4.1.1", + "prop-types": "^15.6.2", + "react-is": "^16.8.6", + "scheduler": "^0.13.6" + }, + "dependencies": { + "react-is": { + "version": "16.8.6", + "resolved": "https://registry.npmjs.org/react-is/-/react-is-16.8.6.tgz", + "integrity": "sha512-aUk3bHfZ2bRSVFFbbeVS4i+lNPZr3/WM5jT2J5omUVV1zzcs1nAaf3l51ctA5FFvCRbhrH0bdAsRRQddFJZPtA==", + "dev": true + } + } + }, "resolve-url": { "version": "0.2.1", "resolved": "https://registry.npmjs.org/resolve-url/-/resolve-url-0.2.1.tgz", diff --git a/packages/components/psammead-media-indicator/package.json b/packages/components/psammead-media-indicator/package.json index 610a0b7363..7097d1f9c6 100644 --- a/packages/components/psammead-media-indicator/package.json +++ b/packages/components/psammead-media-indicator/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-media-indicator", - "version": "1.0.3", + "version": "1.0.4", "main": "dist/index.js", "description": "Provides a play icon and media duration for media page promos", "repository": { @@ -17,13 +17,13 @@ }, "homepage": "https://github.com/bbc/psammead/blob/latest/packages/components/psammead-media-indicator/README.md", "dependencies": { - "@bbc/gel-foundations": "^3.0.0", - "@bbc/psammead-styles": "^0.3.3", - "@bbc/psammead-visually-hidden-text": "^0.1.12" + "@bbc/gel-foundations": "^3.0.1", + "@bbc/psammead-styles": "^1.0.1", + "@bbc/psammead-visually-hidden-text": "^1.0.1" }, "devDependencies": { - "@bbc/psammead-storybook-helpers": "^2.1.1", - "@bbc/psammead-test-helpers": "^0.3.3", + "@bbc/psammead-storybook-helpers": "^3.1.0", + "@bbc/psammead-test-helpers": "^1.0.0", "react": "^16.8.6", "styled-components": "^4.3.2" }, diff --git a/packages/components/psammead-media-indicator/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-media-indicator/src/__snapshots__/index.test.jsx.snap index b8647e6f0c..22400f3d17 100644 --- a/packages/components/psammead-media-indicator/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-media-indicator/src/__snapshots__/index.test.jsx.snap @@ -41,6 +41,12 @@ exports[`MediaIndicator should render audio correctly without duration details 1 height: 100%; } +@media (max-width:24.9375rem) { + .c0 { + padding: 0.25rem 0.25rem 0; + } +} +