From 8f017542756f6f997e8338a976c64c94e9c8df92 Mon Sep 17 00:00:00 2001 From: thekp Date: Tue, 21 Jan 2020 17:08:57 +0000 Subject: [PATCH 1/8] added MostReadSection and removed title --- .../components/psammead-most-read/README.md | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/packages/components/psammead-most-read/README.md b/packages/components/psammead-most-read/README.md index a8fc636aba..19d8394906 100644 --- a/packages/components/psammead-most-read/README.md +++ b/packages/components/psammead-most-read/README.md @@ -218,7 +218,7 @@ import { MostReadRank } from '@bbc/psammead-most-read'; />; ``` -## MostReadTitle +## MostReadSection ### Props @@ -228,17 +228,26 @@ import { MostReadRank } from '@bbc/psammead-most-read'; | script | object | yes | N/A | `{ canon: { groupA: { fontSize: '28', lineHeight: '32',}, groupB: { fontSize: '32', lineHeight: '36', }, groupD: { fontSize: '44', lineHeight: '48', }, }, trafalgar: { groupA: { fontSize: '20', lineHeight: '24', }, groupB: { fontSize: '24', lineHeight: '28', }, groupD: { fontSize: '32', lineHeight: '36', }, }, }` | | service | string | yes | N/A | `'news'` | | header | string | yes | N/A | `'Most Read'` | -| labelId | string | no | `'most-read-title'` | `'most-read-title'` | +| labelId | string | no | `'most-read'` | `'most-read'` | +| children | node | yes | N/A | `{timestamp}` | +| dir | string | no | `"ltr"` | `"ltr"` | ### Usage ```jsx import React from 'react'; import { latin } from '@bbc/gel-foundations/scripts'; -import { MostReadTitle } from '@bbc/psammead-most-read/Title'; - -; +import { MostReadSection } from '@bbc/psammead-most-read'; + +

Most Read content

+; ``` ### When to use this component From 4a1ef27a6019ec734ecd3b81ee185e27b358fab7 Mon Sep 17 00:00:00 2001 From: thekp Date: Tue, 21 Jan 2020 17:09:12 +0000 Subject: [PATCH 2/8] bump package and update changelog --- packages/components/psammead-most-read/CHANGELOG.md | 1 + packages/components/psammead-most-read/package-lock.json | 2 +- packages/components/psammead-most-read/package.json | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/components/psammead-most-read/CHANGELOG.md b/packages/components/psammead-most-read/CHANGELOG.md index 6c0471b75f..7f1b47bfe5 100644 --- a/packages/components/psammead-most-read/CHANGELOG.md +++ b/packages/components/psammead-most-read/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 0.5.2-alpha.5 | [PR#2982](https://github.com/bbc/psammead/pull/2982) Update readme | | 0.5.2-alpha.4 | [PR#2982](https://github.com/bbc/psammead/pull/2982) Talos - Bump Dependencies - @bbc/psammead-grid, @bbc/psammead-section-label | | 0.5.2-alpha.3 | [PR#2983](https://github.com/bbc/psammead/pull/2983) Conditionally render timestamp wrapper | | 0.5.2-alpha.2 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations, @bbc/psammead-grid | diff --git a/packages/components/psammead-most-read/package-lock.json b/packages/components/psammead-most-read/package-lock.json index c2e66433f0..783256fa36 100644 --- a/packages/components/psammead-most-read/package-lock.json +++ b/packages/components/psammead-most-read/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-most-read", - "version": "0.5.2-alpha.4", + "version": "0.5.2-alpha.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-most-read/package.json b/packages/components/psammead-most-read/package.json index 70e786b4ee..4094c4072e 100644 --- a/packages/components/psammead-most-read/package.json +++ b/packages/components/psammead-most-read/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-most-read", - "version": "0.5.2-alpha.4", + "version": "0.5.2-alpha.5", "publishConfig": { "tag": "alpha" }, From a7e39a36e84641dcc659c88ea43c245ea797eaa3 Mon Sep 17 00:00:00 2001 From: Denis Hernandez Date: Wed, 22 Jan 2020 14:28:49 +0000 Subject: [PATCH 3/8] Use new GEL spacing constants --- .../psammead-media-indicator/CHANGELOG.md | 1 + .../psammead-media-indicator/package-lock.json | 2 +- .../psammead-media-indicator/package.json | 2 +- .../psammead-media-indicator/src/index.jsx | 8 ++++++-- .../components/psammead-navigation/CHANGELOG.md | 1 + .../psammead-navigation/package-lock.json | 2 +- .../components/psammead-navigation/package.json | 2 +- .../src/ScrollableNavigation/index.jsx | 3 ++- .../components/psammead-navigation/src/index.jsx | 11 +++++++---- .../components/psammead-script-link/CHANGELOG.md | 1 + .../psammead-script-link/package-lock.json | 2 +- .../components/psammead-script-link/package.json | 2 +- .../components/psammead-script-link/src/index.jsx | 15 ++++++++++----- .../psammead-section-label/CHANGELOG.md | 1 + .../psammead-section-label/package-lock.json | 2 +- .../psammead-section-label/package.json | 2 +- .../psammead-section-label/src/titles.jsx | 2 +- .../psammead-sitewide-links/CHANGELOG.md | 1 + .../psammead-sitewide-links/package-lock.json | 2 +- .../psammead-sitewide-links/package.json | 2 +- .../psammead-sitewide-links/src/List/index.jsx | 2 +- .../psammead-story-promo-list/CHANGELOG.md | 1 + .../psammead-story-promo-list/package-lock.json | 2 +- .../psammead-story-promo-list/package.json | 2 +- .../psammead-story-promo-list/src/index.jsx | 4 ++-- .../components/psammead-story-promo/CHANGELOG.md | 1 + .../psammead-story-promo/package-lock.json | 2 +- .../components/psammead-story-promo/package.json | 2 +- .../components/psammead-story-promo/src/index.jsx | 4 +++- .../components/psammead-useful-links/CHANGELOG.md | 2 ++ .../psammead-useful-links/package-lock.json | 2 +- .../components/psammead-useful-links/package.json | 2 +- .../psammead-useful-links/src/index.jsx | 8 +++----- packages/utilities/psammead-assets/CHANGELOG.md | 1 + .../utilities/psammead-assets/package-lock.json | 2 +- packages/utilities/psammead-assets/package.json | 2 +- .../psammead-assets/src/svgs/mediaIcons.jsx | 2 +- 37 files changed, 64 insertions(+), 41 deletions(-) diff --git a/packages/components/psammead-media-indicator/CHANGELOG.md b/packages/components/psammead-media-indicator/CHANGELOG.md index 47bb2c64d5..8920fc3788 100644 --- a/packages/components/psammead-media-indicator/CHANGELOG.md +++ b/packages/components/psammead-media-indicator/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------- | ----------- | +| 2.6.24 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_QUAD` in `MediaIndicatorWrapper` | | 2.6.23 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 2.6.22 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.6.21 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-media-indicator/package-lock.json b/packages/components/psammead-media-indicator/package-lock.json index a5477a17f3..1ddfbe375d 100644 --- a/packages/components/psammead-media-indicator/package-lock.json +++ b/packages/components/psammead-media-indicator/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-media-indicator", - "version": "2.6.23", + "version": "2.6.24", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-media-indicator/package.json b/packages/components/psammead-media-indicator/package.json index 36684bc5e5..bb9859178c 100644 --- a/packages/components/psammead-media-indicator/package.json +++ b/packages/components/psammead-media-indicator/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-media-indicator", - "version": "2.6.23", + "version": "2.6.24", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-media-indicator/src/index.jsx b/packages/components/psammead-media-indicator/src/index.jsx index 9972f63396..fdb209150c 100644 --- a/packages/components/psammead-media-indicator/src/index.jsx +++ b/packages/components/psammead-media-indicator/src/index.jsx @@ -2,7 +2,11 @@ import React from 'react'; import styled, { css } from 'styled-components'; import { string, oneOf, bool } from 'prop-types'; import { C_WHITE, C_EBON } from '@bbc/psammead-styles/colours'; -import { GEL_SPACING, GEL_SPACING_HLF } from '@bbc/gel-foundations/spacings'; +import { + GEL_SPACING_HLF, + GEL_SPACING, + GEL_SPACING_QUAD, +} from '@bbc/gel-foundations/spacings'; import { GEL_GROUP_1_SCREEN_WIDTH_MAX } from '@bbc/gel-foundations/breakpoints'; import { GEL_MINION } from '@bbc/gel-foundations/typography'; import { getSansRegular } from '@bbc/psammead-styles/font-styles'; @@ -15,7 +19,7 @@ const MediaIndicatorWrapper = styled.div` ${({ service }) => getSansRegular(service)} ${GEL_MINION}; color: ${C_EBON}; - height: 2rem; + height: ${GEL_SPACING_QUAD}; ${({ topStory }) => !topStory && diff --git a/packages/components/psammead-navigation/CHANGELOG.md b/packages/components/psammead-navigation/CHANGELOG.md index 287d37d006..98f11fc92d 100644 --- a/packages/components/psammead-navigation/CHANGELOG.md +++ b/packages/components/psammead-navigation/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 6.0.0-alpha.25 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_HLF` and `GEL_SPACING_SEXT` constants | | 6.0.0-alpha.24 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 6.0.0-alpha.23 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 6.0.0-alpha.22 | [PR#2951](https://github.com/bbc/psammead/pull/2951) Use visually hidden text instead of aria label in nav button | diff --git a/packages/components/psammead-navigation/package-lock.json b/packages/components/psammead-navigation/package-lock.json index dc9b756996..132c1b5650 100644 --- a/packages/components/psammead-navigation/package-lock.json +++ b/packages/components/psammead-navigation/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "6.0.0-alpha.24", + "version": "6.0.0-alpha.25", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-navigation/package.json b/packages/components/psammead-navigation/package.json index bec4d9cf95..9fcbbb1653 100644 --- a/packages/components/psammead-navigation/package.json +++ b/packages/components/psammead-navigation/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-navigation", - "version": "6.0.0-alpha.24", + "version": "6.0.0-alpha.25", "description": "A navigation bar to use on index pages", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-navigation/src/ScrollableNavigation/index.jsx b/packages/components/psammead-navigation/src/ScrollableNavigation/index.jsx index 6b0aea201e..0852765024 100644 --- a/packages/components/psammead-navigation/src/ScrollableNavigation/index.jsx +++ b/packages/components/psammead-navigation/src/ScrollableNavigation/index.jsx @@ -1,6 +1,7 @@ import React from 'react'; import styled, { css } from 'styled-components'; import { node, oneOf } from 'prop-types'; +import { GEL_SPACING_SEXT } from '@bbc/gel-foundations/spacings'; import { GEL_GROUP_2_SCREEN_WIDTH_MAX } from '@bbc/gel-foundations/breakpoints'; /* Convert C_POSTBOX to rgba as IE doesn't like 8 digit hex */ @@ -24,7 +25,7 @@ const StyledScrollableNav = styled.div` &:after { content: ' '; height: 100%; - width: 3rem; + width: ${GEL_SPACING_SEXT}; position: absolute; ${({ dir }) => css` ${dir === 'ltr' ? 'right' : 'left'}: 0; diff --git a/packages/components/psammead-navigation/src/index.jsx b/packages/components/psammead-navigation/src/index.jsx index 43a7155a58..959e60633e 100644 --- a/packages/components/psammead-navigation/src/index.jsx +++ b/packages/components/psammead-navigation/src/index.jsx @@ -8,7 +8,11 @@ import { C_EBON, C_GHOST, } from '@bbc/psammead-styles/colours'; -import { GEL_SPACING_HLF, GEL_SPACING } from '@bbc/gel-foundations/spacings'; +import { + GEL_SPACING_HLF, + GEL_SPACING, + GEL_SPACING_SEXT, +} from '@bbc/gel-foundations/spacings'; import { GEL_GROUP_2_SCREEN_WIDTH_MAX, GEL_GROUP_3_SCREEN_WIDTH_MIN, @@ -21,7 +25,6 @@ import { NAV_BAR_TOP_BOTTOM_SPACING } from './DropdownNavigation'; const SPACING_AROUND_NAV_ITEMS = `${NAV_BAR_TOP_BOTTOM_SPACING}rem`; // 12px const CURRENT_ITEM_HOVER_BORDER = '0.3125rem'; // 5px -const GRADIENT_WIDTH = '3rem'; // 48px /* White with 30% transparency over #B80000 */ const BORDER_COLOR = '#eab3b3'; @@ -77,7 +80,7 @@ const StyledLink = styled.a` &:focus::after { ${ListItemBorder} top: 0; - border: 0.25rem solid ${C_WHITE}; + border: ${GEL_SPACING_HLF} solid ${C_WHITE}; } `; @@ -89,7 +92,7 @@ const StyledListItem = styled.li` @media (max-width: ${GEL_GROUP_2_SCREEN_WIDTH_MAX}) { &:last-child { ${({ dir }) => css` - margin-${dir === 'ltr' ? 'right' : 'left'}: ${GRADIENT_WIDTH}; + margin-${dir === 'ltr' ? 'right' : 'left'}: ${GEL_SPACING_SEXT}; `} } } diff --git a/packages/components/psammead-script-link/CHANGELOG.md b/packages/components/psammead-script-link/CHANGELOG.md index 3cffc92078..70ee564e25 100644 --- a/packages/components/psammead-script-link/CHANGELOG.md +++ b/packages/components/psammead-script-link/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 1.0.6 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING`, `GEL_SPACING_DBL` and `GEL_SPACING_QUIN` constants | | 1.0.5 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 1.0.4 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 1.0.3 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-script-link/package-lock.json b/packages/components/psammead-script-link/package-lock.json index de8e402ed4..e47d4bf7fb 100644 --- a/packages/components/psammead-script-link/package-lock.json +++ b/packages/components/psammead-script-link/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-script-link", - "version": "1.0.5", + "version": "1.0.6", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-script-link/package.json b/packages/components/psammead-script-link/package.json index d2e053912f..d1b431bb92 100644 --- a/packages/components/psammead-script-link/package.json +++ b/packages/components/psammead-script-link/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-script-link", - "version": "1.0.5", + "version": "1.0.6", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-script-link/src/index.jsx b/packages/components/psammead-script-link/src/index.jsx index a30df4b360..4a91667ba0 100644 --- a/packages/components/psammead-script-link/src/index.jsx +++ b/packages/components/psammead-script-link/src/index.jsx @@ -1,5 +1,10 @@ import React from 'react'; import styled from 'styled-components'; +import { + GEL_SPACING, + GEL_SPACING_DBL, + GEL_SPACING_QUIN, +} from '@bbc/gel-foundations/spacings'; import { GEL_GROUP_2_SCREEN_WIDTH_MIN, GEL_GROUP_2_SCREEN_WIDTH_MAX, @@ -18,13 +23,13 @@ const StyledLink = styled.a` text-decoration: none; height: 2.25rem; border: 0.0625rem solid ${C_WHITE}; - margin: 0.5rem 0 0.5rem 0.5rem; + margin: ${GEL_SPACING} 0 ${GEL_SPACING} ${GEL_SPACING}; > span { margin: 0.1875rem; display: inline-block; height: calc(100%); - padding: 0 1rem; + padding: 0 ${GEL_SPACING_DBL}; } &:hover > span, @@ -34,15 +39,15 @@ const StyledLink = styled.a` } @media (min-width: ${GEL_GROUP_2_SCREEN_WIDTH_MIN}) { - line-height: calc(2.25rem - 0.5rem); + line-height: calc(2.25rem - ${GEL_SPACING}); } @media (max-width: ${GEL_GROUP_2_SCREEN_WIDTH_MAX}) { - height: 2.5rem; + height: ${GEL_SPACING_QUIN}; > span { padding: 0 0.75rem; - line-height: calc(2.5rem - 0.5rem); + line-height: calc(${GEL_SPACING_QUIN} - ${GEL_SPACING}); } } `; diff --git a/packages/components/psammead-section-label/CHANGELOG.md b/packages/components/psammead-section-label/CHANGELOG.md index daf08c6e67..1fdd248320 100644 --- a/packages/components/psammead-section-label/CHANGELOG.md +++ b/packages/components/psammead-section-label/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 3.0.12 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_DBL` constant | | 3.0.11 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 3.0.10 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 3.0.9 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-section-label/package-lock.json b/packages/components/psammead-section-label/package-lock.json index cf1ad330f1..1e7925b33c 100644 --- a/packages/components/psammead-section-label/package-lock.json +++ b/packages/components/psammead-section-label/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-section-label", - "version": "3.0.11", + "version": "3.0.12", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-section-label/package.json b/packages/components/psammead-section-label/package.json index b8e7d90192..6b91b058c0 100644 --- a/packages/components/psammead-section-label/package.json +++ b/packages/components/psammead-section-label/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-section-label", - "version": "3.0.11", + "version": "3.0.12", "description": "React styled component for a section label", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-section-label/src/titles.jsx b/packages/components/psammead-section-label/src/titles.jsx index 6ed42284ff..2e292f6183 100644 --- a/packages/components/psammead-section-label/src/titles.jsx +++ b/packages/components/psammead-section-label/src/titles.jsx @@ -64,7 +64,7 @@ const FlexTextRow = styled(FlexRow).attrs({ })``; const titleMargins = ` - margin: 1rem 0; + margin: ${GEL_SPACING_DBL} 0; ${MEDIA_QUERY_TYPOGRAPHY.LAPTOP_AND_LARGER} { margin: 0; diff --git a/packages/components/psammead-sitewide-links/CHANGELOG.md b/packages/components/psammead-sitewide-links/CHANGELOG.md index 774784fcda..a8198cee1a 100644 --- a/packages/components/psammead-sitewide-links/CHANGELOG.md +++ b/packages/components/psammead-sitewide-links/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 4.0.6 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_DBL` constant | | 4.0.5 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 4.0.4 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 4.0.3 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-sitewide-links/package-lock.json b/packages/components/psammead-sitewide-links/package-lock.json index 590f63d7d2..f6674ee26f 100644 --- a/packages/components/psammead-sitewide-links/package-lock.json +++ b/packages/components/psammead-sitewide-links/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-sitewide-links", - "version": "4.0.5", + "version": "4.0.6", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-sitewide-links/package.json b/packages/components/psammead-sitewide-links/package.json index a80985f761..2efee6c5bf 100644 --- a/packages/components/psammead-sitewide-links/package.json +++ b/packages/components/psammead-sitewide-links/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-sitewide-links", - "version": "4.0.5", + "version": "4.0.6", "description": "React styled component for a sitewide-links", "main": "dist/index.js", "module": "esm/index.js", diff --git a/packages/components/psammead-sitewide-links/src/List/index.jsx b/packages/components/psammead-sitewide-links/src/List/index.jsx index 4b1aec534f..e5c31c4334 100644 --- a/packages/components/psammead-sitewide-links/src/List/index.jsx +++ b/packages/components/psammead-sitewide-links/src/List/index.jsx @@ -95,7 +95,7 @@ const StyledList = styled.ul` const StyledListItem = styled.li` min-width: 50%; - column-gap: 1rem; + column-gap: ${GEL_SPACING_DBL}; break-inside: avoid-column; `; diff --git a/packages/components/psammead-story-promo-list/CHANGELOG.md b/packages/components/psammead-story-promo-list/CHANGELOG.md index 3463740f83..59ef7cd60e 100644 --- a/packages/components/psammead-story-promo-list/CHANGELOG.md +++ b/packages/components/psammead-story-promo-list/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------- | ----------- | +| 2.1.26 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_DBL` and `GEL_SPACING_TRPL` constants | | 2.1.25 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 2.1.24 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.1.23 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-story-promo-list/package-lock.json b/packages/components/psammead-story-promo-list/package-lock.json index a40617d0b2..47054860d2 100644 --- a/packages/components/psammead-story-promo-list/package-lock.json +++ b/packages/components/psammead-story-promo-list/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo-list", - "version": "2.1.25", + "version": "2.1.26", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-story-promo-list/package.json b/packages/components/psammead-story-promo-list/package.json index ab015c9207..898f5eed9c 100644 --- a/packages/components/psammead-story-promo-list/package.json +++ b/packages/components/psammead-story-promo-list/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo-list", - "version": "2.1.25", + "version": "2.1.26", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-story-promo-list/src/index.jsx b/packages/components/psammead-story-promo-list/src/index.jsx index 7168b7bf6b..efdb83ae71 100644 --- a/packages/components/psammead-story-promo-list/src/index.jsx +++ b/packages/components/psammead-story-promo-list/src/index.jsx @@ -29,11 +29,11 @@ export const StoryPromoLi = styled.li.attrs({ padding-top: 0; @media (min-width: ${GEL_GROUP_3_SCREEN_WIDTH_MIN}) { - padding-top: 1rem; + padding-top: ${GEL_SPACING_DBL}; } @media (min-width: ${GEL_GROUP_4_SCREEN_WIDTH_MIN}) { - padding-top: 1.5rem; + padding-top: ${GEL_SPACING_TRPL}; } } diff --git a/packages/components/psammead-story-promo/CHANGELOG.md b/packages/components/psammead-story-promo/CHANGELOG.md index 6f87687980..2212fa13c5 100644 --- a/packages/components/psammead-story-promo/CHANGELOG.md +++ b/packages/components/psammead-story-promo/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------- | ----------- | +| 3.0.0-alpha.14 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING` constant in the `LiveLabel` component | | 3.0.0-alpha.13 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 3.0.0-alpha.12 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 3.0.0-alpha.11 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-story-promo/package-lock.json b/packages/components/psammead-story-promo/package-lock.json index 6c18d37739..beac13f660 100644 --- a/packages/components/psammead-story-promo/package-lock.json +++ b/packages/components/psammead-story-promo/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "3.0.0-alpha.13", + "version": "3.0.0-alpha.14", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-story-promo/package.json b/packages/components/psammead-story-promo/package.json index a1c1594b08..df2db9f90b 100644 --- a/packages/components/psammead-story-promo/package.json +++ b/packages/components/psammead-story-promo/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "3.0.0-alpha.13", + "version": "3.0.0-alpha.14", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-story-promo/src/index.jsx b/packages/components/psammead-story-promo/src/index.jsx index 41c2745db3..587009357d 100644 --- a/packages/components/psammead-story-promo/src/index.jsx +++ b/packages/components/psammead-story-promo/src/index.jsx @@ -340,7 +340,9 @@ export const LiveLabel = styled.span.attrs({ 'aria-hidden': 'true' })` color: ${C_POSTBOX}; display: inline-block; ${({ dir }) => - dir === 'rtl' ? 'margin-left: 0.5rem;' : 'margin-right: 0.5rem;'} + dir === 'rtl' + ? `margin-left: ${GEL_SPACING};` + : `margin-right: ${GEL_SPACING};`} `; LiveLabel.propTypes = { diff --git a/packages/components/psammead-useful-links/CHANGELOG.md b/packages/components/psammead-useful-links/CHANGELOG.md index f0777771f7..1cb3f752be 100644 --- a/packages/components/psammead-useful-links/CHANGELOG.md +++ b/packages/components/psammead-useful-links/CHANGELOG.md @@ -1,7 +1,9 @@ # Useful Links Changelog + | Version | Description | |---------|-------------| +| 1.0.13 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_DBL` constant | | 1.0.12 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 1.0.11 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 1.0.10 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-useful-links/package-lock.json b/packages/components/psammead-useful-links/package-lock.json index 91fa7b0256..655a3def4b 100644 --- a/packages/components/psammead-useful-links/package-lock.json +++ b/packages/components/psammead-useful-links/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-useful-links", - "version": "1.0.12", + "version": "1.0.13", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-useful-links/package.json b/packages/components/psammead-useful-links/package.json index cbff9030bc..d070c58a93 100644 --- a/packages/components/psammead-useful-links/package.json +++ b/packages/components/psammead-useful-links/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-useful-links", - "version": "1.0.12", + "version": "1.0.13", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-useful-links/src/index.jsx b/packages/components/psammead-useful-links/src/index.jsx index a445331c99..c1b3f47aa0 100644 --- a/packages/components/psammead-useful-links/src/index.jsx +++ b/packages/components/psammead-useful-links/src/index.jsx @@ -4,9 +4,7 @@ import { getSerifMedium } from '@bbc/psammead-styles/font-styles'; import { C_EBON, C_METAL } from '@bbc/psammead-styles/colours'; import { grid } from '@bbc/psammead-styles/detection'; import { getPica } from '@bbc/gel-foundations/typography'; -import { - GEL_SPACING, // 8 px -} from '@bbc/gel-foundations/spacings'; +import { GEL_SPACING, GEL_SPACING_DBL } from '@bbc/gel-foundations/spacings'; import { GEL_GROUP_3_SCREEN_WIDTH_MIN, GEL_GROUP_2_SCREEN_WIDTH_MAX, @@ -39,7 +37,7 @@ export const UsefulLinksUl = styled.ul.attrs({ role: 'list' })` @media (min-width: ${GEL_GROUP_3_SCREEN_WIDTH_MIN}) { column-count: 2; - column-gap: 1rem; + column-gap: {GEL_SPACING_DBL}; @supports (${grid}) { display: grid; @@ -49,7 +47,7 @@ export const UsefulLinksUl = styled.ul.attrs({ role: 'list' })` ${({ children }) => getRowCount(children, 2)}, auto ); - grid-column-gap: 1rem; + grid-column-gap: ${GEL_SPACING_DBL}; } } `; diff --git a/packages/utilities/psammead-assets/CHANGELOG.md b/packages/utilities/psammead-assets/CHANGELOG.md index a3ea338c40..c06d97dc25 100644 --- a/packages/utilities/psammead-assets/CHANGELOG.md +++ b/packages/utilities/psammead-assets/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 2.11.1 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_DBL` constant in `PhotoMediaIcon`| | 2.11.0 | [PR#2826](https://github.com/bbc/psammead/pull/2826) Add amp ads js script boilerplate | | 2.10.3 | [PR#2694](https://github.com/bbc/psammead/pull/2694) Add properties to hide Navigation Icons from screen readers | | 2.10.2 | [PR#2686](https://github.com/bbc/psammead/pull/2686) Add SVG for Archive brand logo | diff --git a/packages/utilities/psammead-assets/package-lock.json b/packages/utilities/psammead-assets/package-lock.json index 2be186a033..2eb6e253f0 100644 --- a/packages/utilities/psammead-assets/package-lock.json +++ b/packages/utilities/psammead-assets/package-lock.json @@ -1,5 +1,5 @@ { "name": "@bbc/psammead-assets", - "version": "2.11.0", + "version": "2.11.1", "lockfileVersion": 1 } diff --git a/packages/utilities/psammead-assets/package.json b/packages/utilities/psammead-assets/package.json index 5b493152df..7747e5829c 100644 --- a/packages/utilities/psammead-assets/package.json +++ b/packages/utilities/psammead-assets/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-assets", - "version": "2.11.0", + "version": "2.11.1", "sideEffects": false, "description": "A collection of common assets that are likely to be required by many Psammead components or users, such as SVGs or small scripts.", "repository": { diff --git a/packages/utilities/psammead-assets/src/svgs/mediaIcons.jsx b/packages/utilities/psammead-assets/src/svgs/mediaIcons.jsx index 5984bf873f..ead00797e1 100644 --- a/packages/utilities/psammead-assets/src/svgs/mediaIcons.jsx +++ b/packages/utilities/psammead-assets/src/svgs/mediaIcons.jsx @@ -25,7 +25,7 @@ const AudioMediaIcon = styled(MediaIcon)` `; const PhotoMediaIcon = styled(MediaIcon)` - width: 1rem; + width: ${GEL_SPACING_DBL}; height: 0.8125rem; `; From 9ff0cb0cbee0863b737a5df326701318ca192410 Mon Sep 17 00:00:00 2001 From: Denis Hernandez Date: Wed, 22 Jan 2020 14:30:53 +0000 Subject: [PATCH 4/8] Add missing $ --- packages/components/psammead-useful-links/src/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-useful-links/src/index.jsx b/packages/components/psammead-useful-links/src/index.jsx index c1b3f47aa0..ebcda9e1b2 100644 --- a/packages/components/psammead-useful-links/src/index.jsx +++ b/packages/components/psammead-useful-links/src/index.jsx @@ -37,7 +37,7 @@ export const UsefulLinksUl = styled.ul.attrs({ role: 'list' })` @media (min-width: ${GEL_GROUP_3_SCREEN_WIDTH_MIN}) { column-count: 2; - column-gap: {GEL_SPACING_DBL}; + column-gap: ${GEL_SPACING_DBL}; @supports (${grid}) { display: grid; From 3be5957c6325a6842744cd695b3c0037a2cc6c39 Mon Sep 17 00:00:00 2001 From: Denis Hernandez Date: Wed, 22 Jan 2020 14:44:10 +0000 Subject: [PATCH 5/8] Update PR number --- packages/components/psammead-media-indicator/CHANGELOG.md | 2 +- packages/components/psammead-navigation/CHANGELOG.md | 2 +- packages/components/psammead-script-link/CHANGELOG.md | 2 +- packages/components/psammead-section-label/CHANGELOG.md | 2 +- packages/components/psammead-sitewide-links/CHANGELOG.md | 2 +- packages/components/psammead-story-promo-list/CHANGELOG.md | 2 +- packages/components/psammead-story-promo/CHANGELOG.md | 2 +- packages/components/psammead-useful-links/CHANGELOG.md | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/components/psammead-media-indicator/CHANGELOG.md b/packages/components/psammead-media-indicator/CHANGELOG.md index 8920fc3788..2ff2081fcd 100644 --- a/packages/components/psammead-media-indicator/CHANGELOG.md +++ b/packages/components/psammead-media-indicator/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | | ------- | ----------- | -| 2.6.24 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_QUAD` in `MediaIndicatorWrapper` | +| 2.6.24 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING_QUAD` in `MediaIndicatorWrapper` | | 2.6.23 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 2.6.22 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.6.21 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-navigation/CHANGELOG.md b/packages/components/psammead-navigation/CHANGELOG.md index 98f11fc92d..4b6ff30517 100644 --- a/packages/components/psammead-navigation/CHANGELOG.md +++ b/packages/components/psammead-navigation/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 6.0.0-alpha.25 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_HLF` and `GEL_SPACING_SEXT` constants | +| 6.0.0-alpha.25 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING_HLF` and `GEL_SPACING_SEXT` constants | | 6.0.0-alpha.24 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 6.0.0-alpha.23 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 6.0.0-alpha.22 | [PR#2951](https://github.com/bbc/psammead/pull/2951) Use visually hidden text instead of aria label in nav button | diff --git a/packages/components/psammead-script-link/CHANGELOG.md b/packages/components/psammead-script-link/CHANGELOG.md index 70ee564e25..06335cbd39 100644 --- a/packages/components/psammead-script-link/CHANGELOG.md +++ b/packages/components/psammead-script-link/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 1.0.6 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING`, `GEL_SPACING_DBL` and `GEL_SPACING_QUIN` constants | +| 1.0.6 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING`, `GEL_SPACING_DBL` and `GEL_SPACING_QUIN` constants | | 1.0.5 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 1.0.4 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 1.0.3 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-section-label/CHANGELOG.md b/packages/components/psammead-section-label/CHANGELOG.md index 1fdd248320..2c81c7ee6b 100644 --- a/packages/components/psammead-section-label/CHANGELOG.md +++ b/packages/components/psammead-section-label/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 3.0.12 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_DBL` constant | +| 3.0.12 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING_DBL` constant | | 3.0.11 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 3.0.10 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 3.0.9 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-sitewide-links/CHANGELOG.md b/packages/components/psammead-sitewide-links/CHANGELOG.md index a8198cee1a..fa30cddcdb 100644 --- a/packages/components/psammead-sitewide-links/CHANGELOG.md +++ b/packages/components/psammead-sitewide-links/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 4.0.6 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_DBL` constant | +| 4.0.6 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING_DBL` constant | | 4.0.5 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 4.0.4 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 4.0.3 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-story-promo-list/CHANGELOG.md b/packages/components/psammead-story-promo-list/CHANGELOG.md index 59ef7cd60e..51122bc1b6 100644 --- a/packages/components/psammead-story-promo-list/CHANGELOG.md +++ b/packages/components/psammead-story-promo-list/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | | ------- | ----------- | -| 2.1.26 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_DBL` and `GEL_SPACING_TRPL` constants | +| 2.1.26 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING_DBL` and `GEL_SPACING_TRPL` constants | | 2.1.25 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 2.1.24 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 2.1.23 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-story-promo/CHANGELOG.md b/packages/components/psammead-story-promo/CHANGELOG.md index 2212fa13c5..9cff794753 100644 --- a/packages/components/psammead-story-promo/CHANGELOG.md +++ b/packages/components/psammead-story-promo/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | | ------- | ----------- | -| 3.0.0-alpha.14 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING` constant in the `LiveLabel` component | +| 3.0.0-alpha.14 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING` constant in the `LiveLabel` component | | 3.0.0-alpha.13 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 3.0.0-alpha.12 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 3.0.0-alpha.11 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-useful-links/CHANGELOG.md b/packages/components/psammead-useful-links/CHANGELOG.md index 1cb3f752be..0b1f818a98 100644 --- a/packages/components/psammead-useful-links/CHANGELOG.md +++ b/packages/components/psammead-useful-links/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 1.0.13 | [PR#XXX](https://github.com/bbc/psammead/pull/XXX) Use `GEL_SPACING_DBL` constant | +| 1.0.13 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING_DBL` constant | | 1.0.12 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 1.0.11 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 1.0.10 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | From ba22e365b1f581b93a83bd11b9e58501622a8ede Mon Sep 17 00:00:00 2001 From: Denis Hernandez Date: Wed, 22 Jan 2020 16:21:53 +0000 Subject: [PATCH 6/8] Use GEL_SPACING_QUIN in Headline --- packages/components/psammead-headings/CHANGELOG.md | 1 + packages/components/psammead-headings/package-lock.json | 2 +- packages/components/psammead-headings/package.json | 2 +- packages/components/psammead-headings/src/index.jsx | 3 ++- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/components/psammead-headings/CHANGELOG.md b/packages/components/psammead-headings/CHANGELOG.md index 4fb6a82cd9..59e6b36495 100644 --- a/packages/components/psammead-headings/CHANGELOG.md +++ b/packages/components/psammead-headings/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 3.1.25 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Use `GEL_SPACING_QUIN` constant | | 3.1.24 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 3.1.23 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 3.1.22 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-headings/package-lock.json b/packages/components/psammead-headings/package-lock.json index 2ac60ac168..87bbd96999 100644 --- a/packages/components/psammead-headings/package-lock.json +++ b/packages/components/psammead-headings/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-headings", - "version": "3.1.24", + "version": "3.1.25", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-headings/package.json b/packages/components/psammead-headings/package.json index 4280d99ebf..cea64f84e1 100644 --- a/packages/components/psammead-headings/package.json +++ b/packages/components/psammead-headings/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-headings", - "version": "3.1.24", + "version": "3.1.25", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-headings/src/index.jsx b/packages/components/psammead-headings/src/index.jsx index 2861d592fb..257620a521 100644 --- a/packages/components/psammead-headings/src/index.jsx +++ b/packages/components/psammead-headings/src/index.jsx @@ -4,6 +4,7 @@ import { C_SHADOW } from '@bbc/psammead-styles/colours'; import { GEL_SPACING_TRPL, GEL_SPACING_QUAD, + GEL_SPACING_QUIN, } from '@bbc/gel-foundations/spacings'; import { getCanon, getTrafalgar } from '@bbc/gel-foundations/typography'; import { MEDIA_QUERY_TYPOGRAPHY } from '@bbc/gel-foundations/breakpoints'; @@ -18,7 +19,7 @@ export const Headline = styled.h1` margin: 0; /* Reset */ padding: ${GEL_SPACING_QUAD} 0; ${MEDIA_QUERY_TYPOGRAPHY.LAPTOP_AND_LARGER} { - padding: 2.5rem 0; + padding: ${GEL_SPACING_QUIN} 0; } `; From 3f8257a9b32d004012c64f339e1bf0f60fedf2b9 Mon Sep 17 00:00:00 2001 From: Denis Hernandez Date: Wed, 22 Jan 2020 16:28:42 +0000 Subject: [PATCH 7/8] Use constants in stories --- packages/components/psammead-headings/CHANGELOG.md | 2 +- packages/components/psammead-script-link/src/index.stories.jsx | 3 ++- packages/utilities/psammead-assets/CHANGELOG.md | 2 +- packages/utilities/psammead-assets/src/svgs.stories.jsx | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/components/psammead-headings/CHANGELOG.md b/packages/components/psammead-headings/CHANGELOG.md index 59e6b36495..9b5688ef04 100644 --- a/packages/components/psammead-headings/CHANGELOG.md +++ b/packages/components/psammead-headings/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 3.1.25 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Use `GEL_SPACING_QUIN` constant | +| 3.1.25 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Use `GEL_SPACING_QUIN` constant in the `Headline` | | 3.1.24 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 3.1.23 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 3.1.22 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/components/psammead-script-link/src/index.stories.jsx b/packages/components/psammead-script-link/src/index.stories.jsx index f2daa06098..57d90e9caa 100644 --- a/packages/components/psammead-script-link/src/index.stories.jsx +++ b/packages/components/psammead-script-link/src/index.stories.jsx @@ -3,12 +3,13 @@ import { storiesOf } from '@storybook/react'; import { withKnobs, text } from '@storybook/addon-knobs'; import styled from 'styled-components'; import { withServicesKnob } from '@bbc/psammead-storybook-helpers'; +import { GEL_SPACING_DBL } from '@bbc/gel-foundations/spacings'; import notes from '../README.md'; import ScriptLink from './index'; const Container = styled.div` background-color: black; - padding: 1rem; + padding: ${GEL_SPACING_DBL}; height: 100vh; `; diff --git a/packages/utilities/psammead-assets/CHANGELOG.md b/packages/utilities/psammead-assets/CHANGELOG.md index 3de0f825b0..af54093315 100644 --- a/packages/utilities/psammead-assets/CHANGELOG.md +++ b/packages/utilities/psammead-assets/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 2.12.1 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING_DBL` constant in `PhotoMediaIcon`| +| 2.12.1 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING_DBL` constant in `PhotoMediaIcon` and stories container | | 2.12.0 | [PR#2935](https://github.com/bbc/psammead/pull/2935) Add a Clock icon to core icons | | 2.11.0 | [PR#2826](https://github.com/bbc/psammead/pull/2826) Add amp ads js script boilerplate | | 2.10.3 | [PR#2694](https://github.com/bbc/psammead/pull/2694) Add properties to hide Navigation Icons from screen readers | diff --git a/packages/utilities/psammead-assets/src/svgs.stories.jsx b/packages/utilities/psammead-assets/src/svgs.stories.jsx index 9af1f068c5..345dcf313e 100644 --- a/packages/utilities/psammead-assets/src/svgs.stories.jsx +++ b/packages/utilities/psammead-assets/src/svgs.stories.jsx @@ -3,6 +3,7 @@ import styled from 'styled-components'; import { node, number, shape } from 'prop-types'; import { storiesOf } from '@storybook/react'; import { number as numberKnob, withKnobs } from '@storybook/addon-knobs'; +import { GEL_SPACING_DBL } from '@bbc/gel-foundations/spacings'; import notes from '../README.md'; import * as allSvgs from './svgs'; @@ -17,7 +18,7 @@ const Svg = styled.svg` const Container = styled.div` background-color: black; - padding: 1rem; + padding: ${GEL_SPACING_DBL}; height: 100vh; `; From a685bb15cf1a1d4287fe5310af6092f66ee9a99a Mon Sep 17 00:00:00 2001 From: Denis Hernandez Date: Wed, 22 Jan 2020 16:31:00 +0000 Subject: [PATCH 8/8] Update PR number --- packages/components/psammead-headings/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-headings/CHANGELOG.md b/packages/components/psammead-headings/CHANGELOG.md index 9b5688ef04..f8c74c61a7 100644 --- a/packages/components/psammead-headings/CHANGELOG.md +++ b/packages/components/psammead-headings/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 3.1.25 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Use `GEL_SPACING_QUIN` constant in the `Headline` | +| 3.1.25 | [PR#2990](https://github.com/bbc/psammead/pull/2990) Use `GEL_SPACING_QUIN` constant in the `Headline` | | 3.1.24 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | | 3.1.23 | [PR#2973](https://github.com/bbc/psammead/pull/2973) Talos - Bump Dependencies - @bbc/psammead-styles | | 3.1.22 | [PR#2920](https://github.com/bbc/psammead/pull/2920) Talos - Bump Dependencies - @bbc/gel-foundations |