diff --git a/packages/components/psammead-brand/CHANGELOG.md b/packages/components/psammead-brand/CHANGELOG.md index 3b05c1439f..5dd15f5b61 100644 --- a/packages/components/psammead-brand/CHANGELOG.md +++ b/packages/components/psammead-brand/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------- | ----------- | +| 4.1.7 | [PR#787](https://github.com/bbc/psammead/pull/787) Fix brand colour in Firefox high contrast mode | | 4.1.6 | [PR#789](https://github.com/bbc/psammead/pull/789) Use rem for the `BrandSvg` height | | 4.1.5 | [PR#769](https://github.com/bbc/psammead/pull/769) Fix stories not appearing in storybook when using `install:packages:link` | | 4.1.4 | [PR#747](https://github.com/bbc/psammead/pull/747) Add text role to avoid link fragmented on ios voiceover | @@ -32,3 +33,4 @@ | 0.1.2 | [PR#227](https://github.com/BBC-News/psammead/pull/227) Replace @bbc/gel-constants and @bbc/gel-foundations-styled-component with [@bbc/gel-foundations in Psammead](https://github.com/BBC-News/psammead/issues/226). | | 0.1.1 | [PR#202](https://github.com/BBC-News/psammead/pull/202) Fixes a styling bug caused by an [incorrect constant import](https://github.com/BBC-News/psammead/issues/201). | | 0.1.0 | [PR#105](https://github.com/BBC-News/psammead/pull/105) Create initial package, pulled in from [simorgh](https://github.com/BBC-News/simorgh). | + diff --git a/packages/components/psammead-brand/package-lock.json b/packages/components/psammead-brand/package-lock.json index eb3c133b08..416424b765 100644 --- a/packages/components/psammead-brand/package-lock.json +++ b/packages/components/psammead-brand/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-brand", - "version": "4.1.6", + "version": "4.1.7", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -130,9 +130,9 @@ "integrity": "sha512-dHVZ+ig1P/crQtvAOP0bB0PAuuqT2R8hs15pZDsJsO1wvPtbvEe2TO6AxXUIODk9TZgod2j+9K6TB4WV/I2LDw==" }, "@bbc/psammead-assets": { - "version": "0.1.9", - "resolved": "https://registry.npmjs.org/@bbc/psammead-assets/-/psammead-assets-0.1.9.tgz", - "integrity": "sha512-yS8Zp4eknoai+UtIaWjVJiJxQieOYCkH1Mj6QIYON3g0oXVekm9gFDzpB/JNZGa0aavXKBkcuLEj8fz5HT05Fw==", + "version": "1.0.2", + "resolved": "https://registry.npmjs.org/@bbc/psammead-assets/-/psammead-assets-1.0.2.tgz", + "integrity": "sha512-Ps2eogFG4Thr1qn8+pCUSouQZzyplRpm7rYmXxhcCCGoIz5I5ddwHaKo0QW9wZk5mXE1d/0k6xXBV6kYarfUrg==", "dev": true }, "@bbc/psammead-storybook-helpers": { diff --git a/packages/components/psammead-brand/package.json b/packages/components/psammead-brand/package.json index f10588cb26..feeaffc51a 100644 --- a/packages/components/psammead-brand/package.json +++ b/packages/components/psammead-brand/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-brand", - "version": "4.1.6", + "version": "4.1.7", "main": "dist/index.js", "description": "Provides the BBC News logo (as SVG), nested a hardcoded link to https://www.bbc.co.uk/news", "repository": { @@ -22,7 +22,7 @@ "@bbc/psammead-visually-hidden-text": "^0.1.10" }, "devDependencies": { - "@bbc/psammead-assets": "^0.1.9", + "@bbc/psammead-assets": "^1.0.2", "@bbc/psammead-storybook-helpers": "^3.0.0", "@bbc/psammead-test-helpers": "^0.3.3", "react": "^16.8.6", diff --git a/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap index 9aaba6bf21..e0490fecd4 100644 --- a/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap @@ -26,7 +26,8 @@ exports[`Brand should render correctly with link not provided 1`] = ` .c2 { box-sizing: content-box; - fill: #FFFFFF; + color: #FFFFFF; + fill: currentColor; padding-top: 1rem; padding-bottom: 0.75rem; height: 1.5rem; @@ -133,7 +134,8 @@ exports[`Brand should render correctly with link provided 1`] = ` .c4 { box-sizing: content-box; - fill: #FFFFFF; + color: #FFFFFF; + fill: currentColor; padding-top: 1rem; padding-bottom: 0.75rem; height: 1.5rem; @@ -238,7 +240,8 @@ exports[`Brand should render correctly with no service Localised Name 1`] = ` .c2 { box-sizing: content-box; - fill: #FFFFFF; + color: #FFFFFF; + fill: currentColor; padding-top: 1rem; padding-bottom: 0.75rem; height: 1.5rem; @@ -333,7 +336,8 @@ exports[`Brand should render correctly with transparent borders 1`] = ` .c2 { box-sizing: content-box; - fill: #FFFFFF; + color: #FFFFFF; + fill: currentColor; padding-top: 1rem; padding-bottom: 0.75rem; height: 1.5rem; diff --git a/packages/components/psammead-brand/src/index.jsx b/packages/components/psammead-brand/src/index.jsx index 7590104a67..f3d5ce9f66 100644 --- a/packages/components/psammead-brand/src/index.jsx +++ b/packages/components/psammead-brand/src/index.jsx @@ -56,9 +56,11 @@ const StyledLink = styled.a` ${({ maxWidth, minWidth }) => brandWidth(minWidth, maxWidth)} `; +// `currentColor` has been used to address high contrast mode in Firefox. const BrandSvg = styled.svg` box-sizing: content-box; - fill: ${C_WHITE}; + color: ${C_WHITE}; + fill: currentColor; padding-top: ${GEL_SPACING_DBL}; padding-bottom: ${SVG_BOTTOM_OFFSET_BELOW_400PX}; height: ${props => props.height / 16}rem; diff --git a/packages/utilities/psammead-assets/CHANGELOG.md b/packages/utilities/psammead-assets/CHANGELOG.md index 95c37ab0b1..280f4cad1f 100644 --- a/packages/utilities/psammead-assets/CHANGELOG.md +++ b/packages/utilities/psammead-assets/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 1.0.3 | [PR#787](https://github.com/bbc/psammead/pull/787) Fix brand stories in Firefox high contrast mode | | 1.0.2 | [PR#713](https://github.com/bbc/psammead/pull/713) Update `styled-components` to 4.3.2 | | 1.0.1 | [PR#704](https://github.com/bbc/psammead/pull/704) Remove `fill` from SVGs | | 1.0.0 | [PR#679](https://github.com/bbc/psammead/pull/679) Bump version number | diff --git a/packages/utilities/psammead-assets/package-lock.json b/packages/utilities/psammead-assets/package-lock.json index 6267507ca4..7779d723d6 100644 --- a/packages/utilities/psammead-assets/package-lock.json +++ b/packages/utilities/psammead-assets/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-assets", - "version": "1.0.2", + "version": "1.0.3", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/utilities/psammead-assets/package.json b/packages/utilities/psammead-assets/package.json index 59b6a83071..ed5a36208d 100644 --- a/packages/utilities/psammead-assets/package.json +++ b/packages/utilities/psammead-assets/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-assets", - "version": "1.0.2", + "version": "1.0.3", "description": "A collection of common assets that are likely to be required by many Psammead components or users, such as SVGs or small scripts.", "repository": { "type": "git", diff --git a/packages/utilities/psammead-assets/src/svgs.stories.jsx b/packages/utilities/psammead-assets/src/svgs.stories.jsx index 693269a141..ef3690cd36 100644 --- a/packages/utilities/psammead-assets/src/svgs.stories.jsx +++ b/packages/utilities/psammead-assets/src/svgs.stories.jsx @@ -6,9 +6,11 @@ import { number as numberKnob, withKnobs } from '@storybook/addon-knobs'; import notes from '../README.md'; import * as svgs from './svgs'; +// `currentColor` has been used to address high contrast mode in Firefox. const Svg = styled.svg` display: block; - fill: #fff; + color: #fff; + fill: currentColor; `; const Container = styled.div`