Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'az acr task logs' properly handles canceled run #273

Open
northtyphoon opened this issue Sep 12, 2018 · 5 comments
Open

'az acr task logs' properly handles canceled run #273

northtyphoon opened this issue Sep 12, 2018 · 5 comments
Labels

Comments

@northtyphoon
Copy link

After canceling a run, I tried to run az acr task logs. Even the command output the log, it didn't exit but still keep polling until timeout. We probably can check the run status beforehand and then download the log.

@ehotinger
Copy link

What about timing out existing clients? I have a feeling we'd like to support that later once the entire E2E flow is done. But not sure how much value there even really is flowing cancellation from runner -> builder. More important if runner/builder start to be persistent.

@northtyphoon
Copy link
Author

I actually suggest a cheap fix in CLI command. First check if the run is in a terminated (eg, cancel, finish) state. If yes, try download the log once. Otherwise, polling the log until finish or timeout.

@sajayantony
Copy link

Should we close this?

@ehotinger
Copy link

would keep it up, still will look like a bug to users

@sajayantony
Copy link

What do you folks think about actually having Ctrl+c invoke cancel the run with a prompt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants