Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] 2. AddInMemoryTokenCaches and AddDistributedTokenCaches need to use TryAdd instead of Add, not to overwrite any caches added previously (MISE for instance) #2090

Closed
jmprieur opened this issue Feb 27, 2023 · 1 comment
Closed

[Feature Request] 2. AddInMemoryTokenCaches and AddDistributedTokenCaches need to use TryAdd instead of Add, not to overwrite any caches added previously (MISE for instance) #2090

jmprieur opened this issue Feb 27, 2023 · 1 comment
Labels
enhancement New feature or request feature request MISE request
Milestone
2.6.1

Comments

@jmprieur
Copy link
Collaborator

Why?
If an application already sets caches implementing a particular interface, we don't want to override them. If they have not set a cache we should do it

What?
See

microsoft-identity-web/src/Microsoft.Identity.Web.TokenCache/InMemory/InMemoryTokenCacheProviderExtension.cs

Line 22 in 05acc37

services.AddMemoryCache();

@jennyf19 jennyf19 mentioned this issue Mar 8, 2023
Merged
@jennyf19 jennyf19 added this to the 2.6.0 milestone Mar 9, 2023
@westin-m
Copy link
Contributor

Included in the 2.6.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature request MISE request
Projects
None yet
Milestone
2.6.1
Development

No branches or pull requests
3 participants
@jmprieur @jennyf19 @westin-m