Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Service Fabric MI Auth doesn't validate server cert. #758

Closed
bgavrilMS opened this issue Dec 11, 2023 · 2 comments
Closed

[Bug] Service Fabric MI Auth doesn't validate server cert. #758

bgavrilMS opened this issue Dec 11, 2023 · 2 comments
Labels
Bug Something isn't working, needs an investigation and a fix confidential-client For issues related to confidential client apps P2 Normal priority items, should be done after P1

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Dec 11, 2023

Library version used

1.14.4-beta

Java version

8

Scenario

ManagedIdentityClient - managed identity

Is this a new or an existing app?

This is a new app or experiment

Issue description and reproduction steps

Have a look at Azure Identity code here: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java#L1032

Relevant code snippets

No response

Expected behavior

No response

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

No response

Solution and workarounds

Note that any solution should still offer HttpClient extensiblity. So we can't just use MSAL's internal HTTP Client stack. Needs a bit of design first.

See equivalent .NET issue: AzureAD/microsoft-authentication-library-for-dotnet#4462

@bgavrilMS bgavrilMS added needs attention Automatically used when an issue is created through an issue template untriaged Automatically used when an issue is created through an issue template Bug Something isn't working, needs an investigation and a fix P2 Normal priority items, should be done after P1 confidential-client For issues related to confidential client apps and removed needs attention Automatically used when an issue is created through an issue template untriaged Automatically used when an issue is created through an issue template labels Dec 11, 2023
@bgavrilMS
Copy link
Member Author

We have agreed with Azure SDK to not extend the HttpClient factory for this. It is acceptable for MSAL use it's own HttpClient that doesn't go through the extensibility pipeline.

Retry policies etc. are still required.

@Avery-Dunn
Copy link
Collaborator

Fixed in #791 and released in msal4j 1.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working, needs an investigation and a fix confidential-client For issues related to confidential client apps P2 Normal priority items, should be done after P1
Projects
None yet
Development

No branches or pull requests

2 participants