Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] WAM - throw when msalruntime.dll is not found #3699

Closed
1 of 7 tasks
gladjohn opened this issue Sep 23, 2022 · 0 comments · Fixed by #3715
Closed
1 of 7 tasks

[Bug] WAM - throw when msalruntime.dll is not found #3699

gladjohn opened this issue Sep 23, 2022 · 0 comments · Fixed by #3715
Assignees
@gladjohn
Labels
broker bug P2 WAM
Milestone
4.47.2

Comments

@gladjohn
Copy link
Contributor

Logs and network traces
none

Which version of MSAL.NET are you using?
4.47.1

Platform
Net.Core (consuming netstandard 2.0 interop lib)

What authentication flow has the issue?

  • Desktop / Mobile
    • Interactive
    • Integrated Windows Authentication
    • Username Password
    • Device code flow (browserless)
  • Web app
    • Authorization code
    • On-Behalf-Of
  • Daemon app
    • Service to Service calls

Problem?
We only log the failure when interop is not able to load msalruntime.dll, instead we should throw
@gladjohn gladjohn added this to the 4.48.0 milestone Sep 23, 2022
@gladjohn gladjohn self-assigned this Sep 28, 2022
@gladjohn gladjohn moved this from Triage to Estimated/Committed in MSAL Customer Trust / QM Sep 28, 2022
@gladjohn gladjohn moved this from Estimated/Committed to In Progress in MSAL Customer Trust / QM Sep 28, 2022
@gladjohn gladjohn mentioned this issue Sep 28, 2022
Merged
1 task
@pmaytak pmaytak modified the milestones: 4.48.0, 4.47.2 Sep 29, 2022
@bgavrilMS bgavrilMS mentioned this issue Sep 29, 2022
Closed
1 task
Repository owner moved this from In Progress to Fixed in MSAL Customer Trust / QM Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gladjohn gladjohn

Labels
broker bug P2 WAM
Projects
MSAL Customer Trust / QM
Archived in project
Milestone
4.47.2
3 participants
@bgavrilMS @pmaytak @gladjohn