Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Create dashboard with run Kusto query to report on HTTP client errors #3687

Closed
pmaytak opened this issue Sep 20, 2022 · 4 comments
Closed

[Internal] Create dashboard with run Kusto query to report on HTTP client errors #3687

pmaytak opened this issue Sep 20, 2022 · 4 comments
Assignees
@pmaytak
Labels
internal

Comments

@pmaytak
Copy link
Contributor

pmaytak commented Sep 20, 2022 •
edited
Loading

Overview: Before 4.46.2 there were different HTTP client factory implementations in .NET Fx and .NET Core. Based on data .NET Core was more resilient (threw less errors). In 4.46.2, .NET Fx started using the client implementation of .NET Core.

Goal: Create a query to find and compare the number of HTTP related errors pre- and post- 4.46.2 on .NET Core and Fx.

Related: #3546
@pmaytak pmaytak self-assigned this Sep 20, 2022
@bgavrilMS bgavrilMS modified the milestone: 4.48.0 Sep 20, 2022
@pmaytak pmaytak moved this from Triage to In Progress in MSAL Customer Trust / QM Sep 23, 2022
@pmaytak
Copy link
Contributor Author

pmaytak commented Sep 27, 2022

Results are for data between 9/20-9/27. HasFix represents versions 4.46.2 and above. The error count includes: request_timeout, TaskCanceledException, OperationCanceledException. In the first table the error count includes HttpRequestException, in the second table, it's not included.

The rows for before fix, show what is expected - more errors on NetFx than NetCore. The after the fix comparison shows the error percentage is much closer now between frameworks, and NetFx actually has less. I am not sure why the number of errors is much higher for after the fix numbers. There was an error handling refactoring in 4.44. So it could be that the errors counted is more broad than needed. It could also be that maybe the error handling code is more accurate now; and we weren't catching all errors before.

Sku HasFix ErrorCount TotalRequests % Error
MSAL.NetCore 1 6645 301392 2.204770%
MSAL.NetCore 0 9637 968025221 0.000996%
MSAL.Desktop 1 42 46316 0.090681%
MSAL.Desktop 0 105229 935277733 0.011251%
Sku HasFix ErrorCount TotalRequests % Error
MSAL.NetCore 1 5312 301392 1.762489%
MSAL.NetCore 0 9656 968025221 0.000997%
MSAL.Desktop 1 7 46316 0.015114%
MSAL.Desktop 0 105221 935277733 0.011250%

@pmaytak pmaytak moved this from In Progress to Waiting for Code Review in MSAL Customer Trust / QM Sep 27, 2022
@pmaytak pmaytak moved this from Waiting for Code Review to In Progress in MSAL Customer Trust / QM Sep 27, 2022
@bgavrilMS bgavrilMS moved this from In Progress to Blocked/Waiting for reply in MSAL Customer Trust / QM Sep 27, 2022
@pmaytak
Copy link
Contributor Author

pmaytak commented Sep 27, 2022

Moved to Blocked status. Will wait some time, maybe a week, until more requests with new MSAL version come through to increase the sample size. The increase in errors maybe be due to small sample size.

@pmaytak pmaytak changed the title [Feature Request] Create/update a Kusto query to report on HTTP client errors [Feature Request] Create and run Kusto query to report on HTTP client errors Sep 27, 2022
@pmaytak pmaytak changed the title [Feature Request] Create and run Kusto query to report on HTTP client errors [Internal] Create and run Kusto query to report on HTTP client errors Sep 27, 2022
@bgavrilMS bgavrilMS moved this from Blocked/Waiting for reply to Estimated/Committed in MSAL Customer Trust / QM Oct 31, 2022
@bgavrilMS bgavrilMS changed the title [Internal] Create and run Kusto query to report on HTTP client errors [Internal] Create dashboard with run Kusto query to report on HTTP client errors Oct 31, 2022
@bgavrilMS bgavrilMS added this to the Fundamentals milestone Oct 31, 2022
@bgavrilMS
Copy link
Member

We should discuss with data team about best practices here before having a dashboard. Maybe looking at past 1 week is enough?

@pmaytak pmaytak moved this from Estimated/Committed to In Progress in MSAL Customer Trust / QM Nov 4, 2022
@pmaytak
Copy link
Contributor Author

pmaytak commented Nov 10, 2022

Update: Created some error-related queries. Added details in #3546 and sent via email.

@pmaytak pmaytak moved this from In Progress to Blocked/Waiting for reply in MSAL Customer Trust / QM Nov 11, 2022
@bgavrilMS bgavrilMS closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
@github-project-automation github-project-automation bot moved this from Blocked/Waiting for reply to Fixed in MSAL Customer Trust / QM Sep 7, 2023
@pmaytak pmaytak removed this from the Fundamentals milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmaytak pmaytak

Labels
internal
Projects
MSAL Customer Trust / QM
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bgavrilMS @pmaytak