Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Upgrade Newtonsoft to the latest version #3413

Closed
2 tasks done
SameerK-MSFT opened this issue Jun 22, 2022 · 5 comments · Fixed by #3521
Closed
2 tasks done

[Bug] Upgrade Newtonsoft to the latest version #3413

SameerK-MSFT opened this issue Jun 22, 2022 · 5 comments · Fixed by #3521
Assignees
@trwalke
Labels
bug P2
Milestone
4.46.1

Comments

@SameerK-MSFT
Copy link
Contributor

SameerK-MSFT commented Jun 22, 2022 •
edited by trwalke
Loading

Logs and network traces
NA

Which version of MSAL.NET are you using?
4.44

Platform
Applicable to all

issue?
GitHub has warning to upgrade Newtonsoft. Ref: https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/security/dependabot

Possible solution

  • Upgrade Newtonsoft references (PRs here)
  • Upgrade Newtonsoft direct source code ref
@bgavrilMS
Copy link
Member

We also need to upgrade Newtonsoft version in MSAL.

@bgavrilMS bgavrilMS changed the title [Bug] Remove GitHub warnings [Bug] Upgrade newtonsoft Jun 23, 2022
@bgavrilMS bgavrilMS added this to the 4.46.0 milestone Jun 24, 2022
@bgavrilMS bgavrilMS mentioned this issue Jun 24, 2022
Closed
7 tasks
@bgavrilMS
Copy link
Member

newtonsoft fix here: https://github.com/JamesNK/Newtonsoft.Json/pull/2462/files

@bgavrilMS bgavrilMS added P2 and removed P1 labels Jun 24, 2022
@bgavrilMS
Copy link
Member

Unlikely to affect MSAL, since we do not parse JSON coming from external sources.

@bgavrilMS
Copy link
Member

This was alraedy done for Wilson if you need inspiration.

@pmaytak pmaytak changed the title [Bug] Upgrade newtonsoft [Bug] Upgrade Newtonsoft to the latest version Jul 16, 2022
@trwalke trwalke self-assigned this Jul 20, 2022
@bgavrilMS bgavrilMS moved this to In Progress in MSAL Customer Trust / QM Jul 22, 2022
@bgavrilMS
Copy link
Member

@trwalke - please coordinate with @pmaytak on this one or pick something else.

@trwalke trwalke mentioned this issue Jul 25, 2022
Merged
1 task
@trwalke trwalke linked a pull request Jul 25, 2022 that will close this issue
Update MSAL's Newton.Json version to 13.0.1 #3521
Merged
1 task
@trwalke trwalke mentioned this issue Jul 28, 2022
Merged
1 task
@bgavrilMS bgavrilMS mentioned this issue Jul 28, 2022
Closed
@trwalke trwalke moved this from In Progress to Waiting for Code Review in MSAL Customer Trust / QM Jul 28, 2022
@bgavrilMS bgavrilMS moved this from Waiting for Code Review to In Progress in MSAL Customer Trust / QM Aug 2, 2022
@pmaytak pmaytak modified the milestones: 4.46.0, 4.47.0 Aug 3, 2022
Repository owner moved this from In Progress to Fixed in MSAL Customer Trust / QM Aug 8, 2022
@pmaytak pmaytak modified the milestones: 4.47.0, 4.46.1 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trwalke trwalke

Labels
bug P2
Projects
MSAL Customer Trust / QM
Archived in project
Milestone
4.46.1
Development

Successfully merging a pull request may close this issue.

Update MSAL's Newton.Json version to 13.0.1 AzureAD/microsoft-authentication-library-for-dotnet
4 participants
@bgavrilMS @trwalke @pmaytak @SameerK-MSFT