Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Update json serialization library to System.Text.Json #1550

Closed
henrik-me opened this issue Dec 19, 2019 · 3 comments · Fixed by #3605
Closed

[Feature Request] Update json serialization library to System.Text.Json #1550

henrik-me opened this issue Dec 19, 2019 · 3 comments · Fixed by #3605
Assignees
@pmaytak
Labels
Feature Request internal performance

Comments

@henrik-me
Copy link
Contributor

Replace json serialization/deserialization to use
https://www.nuget.org/packages/System.Text.Json/
@bgavrilMS
Copy link
Member

This is not achievable because System.Text.Json does not support all the frameworks MSAL is built againt:

TFM MSAL System.Text.Json
net classic 4.5 4.6.1
net standard 1.3 2.0
UAP 10 10.0.16
Android 9 10

@tipa tipa mentioned this issue Jun 24, 2022
Closed
7 tasks
@bgavrilMS bgavrilMS reopened this Jun 24, 2022
@bgavrilMS bgavrilMS removed the wontfix label Jun 24, 2022
@bgavrilMS
Copy link
Member

The TFMs are no longer relevant and we should explore moving to system.text

@pmaytak pmaytak linked a pull request Jun 28, 2022 that will close this issue
Initial port to System.Text.Json. #3428
Closed
@pmaytak pmaytak self-assigned this Jul 16, 2022
@pmaytak
Copy link
Contributor

pmaytak commented Jul 16, 2022

Related migration doc.

@pmaytak pmaytak linked a pull request Jul 18, 2022 that will close this issue
Port to System.Text.Json + Source Generators for JSON parsing + enable ILTrimming #3435
Closed
@bgavrilMS bgavrilMS moved this to In Progress in MSAL Customer Trust / QM Jul 22, 2022
@bgavrilMS bgavrilMS moved this from In Progress to Estimated/Committed in MSAL Customer Trust / QM Jul 22, 2022
@pmaytak pmaytak moved this from Estimated/Committed to In Progress in MSAL Customer Trust / QM Aug 15, 2022
@pmaytak pmaytak mentioned this issue Aug 16, 2022
Merged
@pmaytak pmaytak added this to the 4.47.0 milestone Aug 26, 2022
@pmaytak pmaytak moved this from In Progress to Waiting for Code Review in MSAL Customer Trust / QM Aug 26, 2022
Repository owner moved this from Waiting for Code Review to Fixed in MSAL Customer Trust / QM Sep 2, 2022
@pmaytak pmaytak modified the milestones: 4.47.0, 4.48.0 Sep 16, 2022
@pmaytak pmaytak added the .NET6 label Sep 17, 2022
@pmaytak pmaytak removed this from the 4.48.0 milestone Sep 29, 2022
@pmaytak pmaytak added this to the Future Minor Version milestone Sep 29, 2022
@pmaytak pmaytak moved this from Fixed to Blocked/Waiting for reply in MSAL Customer Trust / QM Sep 29, 2022
@pmaytak pmaytak mentioned this issue Sep 29, 2022
Closed
@pmaytak pmaytak moved this from Blocked/Waiting for reply to Fixed in MSAL Customer Trust / QM Nov 4, 2022
@pmaytak pmaytak removed this from the Future Minor Version milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmaytak pmaytak

Labels
Feature Request internal performance
Projects
MSAL Customer Trust / QM
Archived in project
Milestone
No milestone
3 participants
@bgavrilMS @pmaytak @henrik-me