-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSAL running on HoloLens Unity app generates deserialization error: No set method for property 'Claims' in type 'Microsoft.Identity.Client.OAuth2.OAuth2ResponseBase' #1185
Comments
Some additional detail: Stepping through OAuth2Client.cs,
|
Having the same issue, did a rollback to 2.7.1.0, now the error is: |
Yeah, it'll complain about whichever member field is declared last in the class. So in your case of 2.7.1.0, I expect ErrorDescription is that last member. As an experiment, I copied these same classes into my own Unity scripts, and tried deserializing the same json response and I don't repro the deserialization error. |
Found solution when working on IL2CPP backend - it is connected to IL2CPP stripping the assemblies. |
@cdacle, @rfurmaniak : does it also work for you? |
This is definitely Unity's IL2CPP bytecode stripping. I don't think you working on MSAL can do anything about it, other than mention it in the docs somewhere. |
We replaced the serialization to use Newtonsoft internally, to overcome these type of bugs. Hopefully this is fixed. Please reopen if issue still persists. |
Which Version of MSAL are you using ?
MSAL 3.0.8
Platform
UWP Hololens Unity App
What authentication flow has the issue?
Other? - please describe;
Is this a new or existing app?
c. This is a new app or experiment
Repro
The same runtime exception below will repro with calls to
AcquireTokenByUsernamePassword
,AcquireTokenByIntegratedWindowsAuth
,AcquireTokenSilent
,AcquireTokenWithDeviceCode
Expected behavior
API successfully returns access token
Actual behavior
Runtime exception, with hresult = -2146233088
Possible Solution
Additional context/ Logs / Screenshots
I repro something similar with ADAL which complains about a different property. ADAL Issue here
The text was updated successfully, but these errors were encountered: