Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swa init does not detect Angular application-builder output directory #843

Open
adrianhall opened this issue May 30, 2024 · 1 comment
Open
Assignees
Labels
command: init All issues related to the init command priority: high (P0) High priority runtime: static Issues related a static app (not API) scope: app Issues related to the user's application static app type: bug Something isn't working version: ga Issues related to major/GA releases
Milestone

Comments

@adrianhall
Copy link
Member

Describe the bug

I have an Angular v18 app created with:

npx ng new app-name

Running swa init --yes sets the outputLocation to "dist\app-name".
The "angular.json" show projects > app-name > architect > build > options > outputPath is dist/app-name (so it's technically correct)

A recent change in the Angular system now places the files in dist/app-name/browser. This location is configurable. This is explicitly the case when the default builder (@angular-devkit/build-angular:application) is used. See angular/angular-cli#26304 for a discussion of the problem.

To Reproduce
Steps to reproduce the behavior:

ng new app-name
cd app-name
swa init --yes

Expected behavior

The SWA CLI should properly detect the output path based on the angular.json settings.

@adrianhall adrianhall added type: bug Something isn't working priority: high (P0) High priority scope: app Issues related to the user's application static app runtime: static Issues related a static app (not API) version: ga Issues related to major/GA releases command: init All issues related to the init command labels Jun 28, 2024
@adrianhall adrianhall added this to the 1.1.11 milestone Jun 28, 2024
@Timothyw0 Timothyw0 self-assigned this Jul 8, 2024
@adrianhall
Copy link
Member Author

We are going to put all the framework detection code into its own library for re-use (since that was where it came from!) This task will be moved over there and will be incorporated as part of the move to that library. Moving out of this release to accomodate that plan of action.

@adrianhall adrianhall modified the milestones: 2.0.0, 2.1.0 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command: init All issues related to the init command priority: high (P0) High priority runtime: static Issues related a static app (not API) scope: app Issues related to the user's application static app type: bug Something isn't working version: ga Issues related to major/GA releases
Projects
None yet
Development

No branches or pull requests

2 participants