updated "show ntp" to use cgexec when management vrf is enabled #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Sep 7, 2019
jleveque
approved these changes
Sep 9, 2019
wendani
reviewed
Jan 24, 2020
| if 'mgmtVrfEnabled' in mvrf_dict['vrf_global']: | ||
| if (mvrf_dict['vrf_global']['mgmtVrfEnabled'] == "true"): | ||
| #ManagementVRF is enabled. Call ntpq using cgexec | ||
| ntpcmd = "cgexec -g l3mdev:mgmt ntpq -p -n" |
There was a problem hiding this comment.
This command should be run with sudo privilege by either prepending the ntpcmd string or running show ntp with sudo
$ show ntp
cgroup change of group failed
$ sudo show ntp
remote refid st t when poll reach delay offset jitter
==============================================================================
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When management VRF is enabled, the linux command/exe "ntpq" should be called using "cgexec -g l3mdev:mgmt".
"show ntp" is updated for the same.
Result of "show ntp" after enabling management VRF using "config vrf add mgmt" is as follows.
root@sonic:~# show ntp
remote refid st t when poll reach delay offset jitter
23.92.29.245 .STEP. 16 u - 256 0 0.000 0.000 0.000
*204.2.134.164 44.24.199.34 3 u 31 64 377 201.063 0.444 0.514
root@sonic:~#