-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config/show]: split vlan into separate file #1038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will enable converge on this report soon. |
lguohan
commented
Aug 9, 2020
lguohan
commented
Aug 9, 2020
lguohan
commented
Aug 9, 2020
lguohan
commented
Aug 9, 2020
lguohan
commented
Aug 9, 2020
lguohan
commented
Aug 9, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lguohan
commented
Aug 9, 2020
jleveque
suggested changes
Aug 9, 2020
- add vlan.py in config and show - add extensive unit tests for vlan Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
This pull request fixes 1 alert when merging 6c98714 into fec442e - view on LGTM.com fixed alerts:
|
jleveque
previously approved these changes
Aug 9, 2020
jleveque
reviewed
Aug 9, 2020
Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
@jleveque , find some missing scenarios not cover by unit test. add one unit test to cover it. |
jleveque
suggested changes
Aug 9, 2020
Signed-off-by: Guohan Lu <[email protected]>
jleveque
approved these changes
Aug 9, 2020
This pull request fixes 1 alert when merging 0cbabd9 into 33ba594 - view on LGTM.com fixed alerts:
|
Closed
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu [email protected]
- What I did
- How I did it
- How to verify it
unit test
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)