This repository has been archived by the owner on Aug 31, 2022. It is now read-only.
SONiC Management Framework Release 1.0 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oadcom_sonic branch Change-Id: I24c1c67ed275a5d01e32d568ef9c8d57da424d9c
The Debian files attempt to run make check for the gNMI server, however, it fails on a build machine, because it expects the Redis server to be available and listening on localhost port 6379. For now, the result of the test is ignored, and we have to find a way to fix this so that the tests work even on a build machine.
Merge PoC changes to master
Buildimage refactor
Add back install and other targets to fix deb package
Add gnmi set and get client to build
trigger building ocbinds file in translib, add gnmi_clients
Fix build issue
Subscribe support
Ad once channel cleanup
Sample subscribe
Sounds good. As I said before, two main stuff in this PR: other stuff like converting the mgmt-framework to use go modules and making the dependency as library could be done in following PR later. |
|
@dzhangalibaba We will take care of the two things in this PR itself. |
Release 1.0 gomod merge
|
I have completed the conversion for our telemetry to use go modules. I also restored the location of all the files, so you can see only 19 files are reporting as changed now. I tested everything is building correctly with go modules. I will post tests results shortly. |
|
The tests have exact json output matching, some of your original tests are failing because there are new fields in the interfaces for example. Are these tests passing for you currently? |
@seiferteric Yes, I got all cases passed . Below output for your reference. |
|
Okay, the issue is that if I run the existing tests on a switch, the DB is not in a pristine state, so the output will have extra data. On my build host, all of the existing tests pass, but our new tests depend on being on the switch, so they fail on the build host. Below you can see all of the existing tests passing and our new tests failing because it is run on the build host: |
|
we should make new test cases passed on build host as well |
|
@dzhangalibaba with my latest commit, all tests are passing. |
… in the build container
|
Here is the build and test output. |
|
retest this please. |
output.txt |
|
Build can't succeed until this PR & corresponding buildimage PR #3488 gets checked-in, due to cross-dependencies. Hence submitting to unblock. |
|
Hi,@PrabhuSreenivasan and @anand-kumar-subramanian |
qiluo-msft
reviewed
Jul 1, 2022
| /usr/local/go/bin/go test -v github.com/Azure/sonic-telemetry/dialout/dialout_client | ||
| sudo mkdir -p /usr/models/yang || true | ||
| sudo find $(GO_MGMT_PATH)/models -name '*.yang' -exec cp {} /usr/models/yang/ \; | ||
| -$(GO) test -mod=vendor -v github.com/Azure/sonic-telemetry/gnmi_server |
There was a problem hiding this comment.
Why ignore the test failure? There is an issue to track https://github.com/Azure/sonic-telemetry/issues/110
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONiC Management Framework Release 1.0