PVSTP feature implementation. #1058
Conversation
- Added new stpmgr for STP config handling - Added changes in orchagent for STP programming via SAI APIs
orchagent/portsorch.cpp
Outdated
| @@ -3378,6 +3549,336 @@ bool PortsOrch::removeAclTableGroup(const Port &p) | |||
| return true; | |||
| } | |||
|
|
|||
|
|
|||
| sai_object_id_t PortsOrch::getStpInstanceOid(sai_uint16_t stp_instance) | |||
There was a problem hiding this comment.
Adding STP functions to portsorch has considerably increased the file size. I think STP functions should be handled separately and not overload portsorch. Like an stporch.cpp
There was a problem hiding this comment.
Hi Prince, Considering STP has limited data and is part of vlan and port we included the code as part of portsorch. This has undergone extensive testing and might be risky to change at this point of time. We have additional spanning-tree features in the next release as part of which we will move this to separate file, hope thats acceptable. Thanks.
There was a problem hiding this comment.
I tend to disagree. Portsorch is not intended to handle protocol aspects and this is an overload. It is better to address/finalize this now than a later churn.
There was a problem hiding this comment.
Separated STP changes from portsorch. Please review the latest commit/changes
- Separated STP changes from portsorch
|
Build failure is because of dependency in sonic-swss-common: orchdaemon.cpp: In member function 'bool OrchDaemon::init()': |
|
need vs test. |
would you be able to share a link to "spytest automation" please |
Previously log rotate was performed after request and on first log line that was recorded which caused delay and issues with syslog logrotate when sending HUP signal, actual log rotate was not performed and handle to a sairedis.rec was sill open preventing logrotate from happening.
What I did
Why I did it
To support PVSTP feature
How I verified it
Spytest automation and also manual verification on VS
Details if related