Implementation changes for CiscoBgp4MIB #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STATE_DB instead of getting data from vtysh. Update unit-test mock table to add new table with BGP Neighbour information. Signed-off-by: SuvarnaMeenakshi <[email protected]>
Sort oid list. Signed-off-by: SuvarnaMeenakshi <[email protected]>
Remove usage of mock vtysh socket and vtysh dummy output. Signed-off-by: SuvarnaMeenakshi <[email protected]>
not required for CiscoBgp4MIB. Signed-off-by: SuvarnaMeenakshi <[email protected]>
|
This pull request fixes 1 alert when merging ade4e38 into 1a2b62a - view on LGTM.com fixed alerts:
|
qiluo-msft
reviewed
Sep 1, 2020
| neigh_str = neigh_key.decode() | ||
| neigh_str = neigh_str.split('|')[1] | ||
| neigh_info = self.db_conn[db_index].get_all(mibs.STATE_DB, neigh_key, blocking=False) | ||
| if neigh_info is None: |
There was a problem hiding this comment.
Suggested change
| if neigh_info is None: | |
| if neigh_info: | |
| ``` #Closed |
There was a problem hiding this comment.
Update the condition check/
qiluo-msft
reviewed
Sep 1, 2020
| @@ -18,8 +17,7 @@ | |||
| from ax_interface.constants import PduTypes | |||
| from sonic_ax_impl.mibs.ietf import rfc4363 | |||
| from sonic_ax_impl.main import SonicMIB | |||
| from sonic_ax_impl.lib.quaggaclient import parse_bgp_summary | |||
| from mock_tables.socket import MockGetHostname | |||
| from sonic_ax_impl.mibs.vendor.cisco.bgp4 import CiscoBgp4MIB | |||
There was a problem hiding this comment.
CiscoBgp4MIB [](start = 49, length = 12)
Not used?
There was a problem hiding this comment.
quaggaclient and mock tables are not required anymore.
Signed-off-by: SuvarnaMeenakshi <[email protected]>
|
This pull request fixes 1 alert when merging 99f3b76 into 1a2b62a - view on LGTM.com fixed alerts:
|
qiluo-msft
approved these changes
Sep 8, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 28, 2020
* [BGP]: Currently the data required for CiscoBgp4MIB is retrieved from bgpd deamon. snmp_ax_impl connects to bgpd daemon via tcp socket and retreives the BGP neighbor information required for CiscoBgp4MIB. This design is modified to support multi-asic platform. The data required by CiscoBgp4MIB can be populated in STATE_DB by a new daemon in BGP docker. Changes made: - snmp_ax_impl to retrieve NEIGH_STATE_TABLE from STATE_DB. This change will affect both single and multi asic platforms. - Update bgp MIB unit tests to use STATE_DB data instead of using vtysh socket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Currently the data required for CiscoBgp4MIB is retrieved from bgpd deamon. snmp_ax_impl connects to bgpd daemon via tcp socket and retreives the BGP neighbor information required for CiscoBgp4MIB. This design is modified to support multi-asic platform. The data required by CiscoBgp4MIB can be populated in STATE_DB by a new daemon in BGP docker.
This PR captures changes required in snmp_ax_impl to get data from STATE_DB.
This PR has dependency on the below PRs:
sonic-net/sonic-buildimage#5329
sonic-net/sonic-buildimage#5436
- How I did it
Changes made so that snmp_ax_impl can talk to STATE_DB and retrieve NEIGH_STATE_TABLE. This change will affect both single and multi asic platforms. In case of multi-asic platforms, snmp_ax_impl will retrive data from STATE_DB of all namespaces.
- How to verify it
Bring up single asic platform and multi-asic platforms with the changes, the output of iso.3.6.1.4.1.9.9.187.
Verify if the output matches with the information in STATE_DB NEIGH_STATE_TABLE.
- Description for the changelog