Use translib's new api-tests app in REST gotest #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Modified ProcessXXX testcases to use new api-tests app instead of ACL app. This allows running end-to-end positive and negative tests without depending on db state and ACL logic. Added few more test cases. 2) Added a new tool rest-gotest.sh to run REST server tests from source or already built test binary. Can be used with tparse or gotestsum too. rest-gotest.sh /* run all tests from source */ rest-gotest.sh -bin /* run already built test binary */ rest-gotest.sh -run Process /* run only ProcessXXX tests */ rest-gotest.sh -bin -json | tparse gotestsum -f testname --raw-command -- rest-gotest.sh -json Signed-off-by: Sachin Holla <[email protected]>
|
retest this please |
renukamanavalan
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
REST go tests were failing due to failures in ACL request.
- How I did it
1) Modified ProcessXXX testcases to use new api-tests app instead of ACL
app. This allows running end-to-end positive and negative tests without
depending on db state and ACL logic. Added few more test cases.
Depends on sonic-net/sonic-mgmt-common#13.
2) Added few more negative test cases to test translib integration.
3) Added a new tool rest-gotest.sh to run REST server tests from source
or already built test binary. Can be used with tparse or gotestsum too.
- How to verify it
REST server gotest
- Description for the changelog
Use translib's new api-tests app in REST gotest