SONiC MAC ACL Yang model update to add support for Source MAC, Destination MAC, Ethertype pattern update, VLAN_ID, PCP, DEI fields. #7917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bingwang-ms
reviewed
Jun 23, 2021
bingwang-ms
previously approved these changes
Jul 2, 2021
|
branch conflicts need be resolved before merge. |
qiluo-msft
previously approved these changes
Dec 2, 2021
abhishekd-brcm
dismissed stale reviews from qiluo-msft and bingwang-ms
via
e9a63f3
abhishekd-brcm
force-pushed
the
mac_acl_yang_model
branch
from
1d48107 to
e9a63f3
Compare
qiluo-msft
reviewed
Dec 2, 2021
|
@bingwang-ms Could you also help review? |
abhishekd-brcm
force-pushed
the
mac_acl_yang_model
branch
from
e9a63f3 to
634685d
Compare
qiluo-msft
added
the
Request for 202111 Branch
qiluo-msft
reviewed
Dec 2, 2021
qiluo-msft
reviewed
Dec 2, 2021
qiluo-msft
reviewed
Dec 2, 2021
abhishekd-brcm
force-pushed
the
mac_acl_yang_model
branch
from
634685d to
48f63f6
Compare
abhishekd-brcm
changed the title
abhishekd-brcm
force-pushed
the
mac_acl_yang_model
branch
from
48f63f6 to
28c6e10
Compare
ganglyu
previously approved these changes
Dec 3, 2021
ganglyu
reviewed
Dec 3, 2021
abhishekd-brcm
force-pushed
the
mac_acl_yang_model
branch
from
28c6e10 to
e9b69cc
Compare
ganglyu
reviewed
Dec 4, 2021
abhishekd-brcm
force-pushed
the
mac_acl_yang_model
branch
from
e9b69cc to
16d1a41
Compare
ganglyu
reviewed
Dec 8, 2021
src/sonic-yang-models/tests/yang_model_tests/tests_config/acl.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Abhishek Dharwadkar <[email protected]>
abhishekd-brcm
force-pushed
the
mac_acl_yang_model
branch
from
16d1a41 to
ceb7ead
Compare
ganglyu
approved these changes
Dec 8, 2021
|
/azp run |
|
Commenter does not have sufficient privileges for PR 7917 in repo Azure/sonic-buildimage |
|
/azpw run |
1 similar comment
|
/azpw run |
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Dec 9, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Dec 27, 2021
… Destination MAC, Ethertype pattern update, VLAN_ID, PCP, DEI fields (#7917) #### Why I did it Currently only IP ACL and related model is defined. Support for MAC ACL is missing. Added support for it. #### How I did it ACL_RULE table is added with new MAC ACL related fields namely Source MAC, Destination MAC, Ethertype (Pattern updated to match any valid Ethertypes), VLAN, PCP, DEI #### How to verify it Yang model tests are attached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhishek Dharwadkar [email protected]
Why I did it
Currently only IP ACL and related model is defined. Support for MAC ACL is missing. Added support for it.
How I did it
ACL_RULE table is added with new MAC ACL related fields namely Source MAC, Destination MAC, Ethertype (Pattern updated to match any valid Ethertypes), VLAN, PCP, DEI
How to verify it
Yang model tests are attached.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Add support for MAC ACL yang model.
A picture of a cute animal (not mandatory but encouraged)