Showtech sonic mgmt framework: Add Management Framework functionality for "show tech-support" #7816
Conversation
…_framework Merging updates from the Azure sonic-buildimage repo on 05/26/2021.
Provide changes needed for the Dell Enterprise version of this feature to make it compatible with the SONiC Community code base.
Provide changes to address code review comments:
- Invoke the generate_dump script using subprocess.run instead of
subprocess.check_output.
- Use output encoding in the subprocess.run call to eliminate
post-execution decoding of text.
- Delete unnecessary pattern matching of output for the "success"
case.
|
I have made changes to the "showtech.py" file in response to code review comments and have re-tested the resulting image build to verify correct behavior for exception and successful completion cases. |
- Address a remaining PR code review comment by directly using
the "returncode" value provided by "subprocess" execution.
- Add filtering of output to extract only the output filename.
(This eliminates extraneous output that could otherwise be
seen in some non-error cases when invoking "show-techsupport"
via the REST API or gNOI.)
|
I have pushed additional changes to address reviewer comments recommending direct usage of the "returncode" value provided by "subprocess.run" execution and to fix a problem that could otherwise occur for "show tech-support" invocation via REST API and gNOI invocation. A corresponding change has also been made for the sonic-management-framework PR (sonic-net/sonic-mgmt-common#49) to provide better output information for REST server invocation errors and to fix an lgtm alert. |
Merge "latest" Azure master branch changes to the showtech branch.
The following submodules were inadvertently added to this PR and need to be removed from the PR: - src/sonic-mgmt-common and src/sonic-mgmt-framework: These submodules were added prematurely. A separate commit (or new PR) will need to be done for them after the pending PRs for both submodules have been merged to the Azure "master" branch. - src/sonic-frr/frr: Added accidentally; no relevance for this PR.
|
/azpw run |
1 similar comment
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
reviewed |
Restore the setting of the "ENABLE_HOST_SERVICE_ON_START" flag to "n" to disable startup of the sonic-hostservices service during initialization. This change is being made in order to resolve the only remaining issue for the associated set of PRs.
|
I have pushed a change to resolve the only remaining issue for this PR. The change reverts the setting of the "ENABLE_HOST_SERVICE_ON_START" flag |
|
/azpw run |
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
Commenter does not have sufficient privileges for PR 7816 in repo Azure/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/azpw run |
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Provide the changes required for supporting the "show-techsupport" command via the SONiC Management Framework front end mechanisms (CLI, REST, and gNOI). The Management Framework functionality implemented by this PR improves on the the capabilities currently provided by the SONiC Click CLI interface via the "show techsupport" command by providing the following additional features:
Unit test results are attached to this PR.
unit_test_log_0607.txt
Why I did it
The proposed changes improve on the the capabilities currently provided by the SONiC Click CLI interface via the "show techsupport" command by providing the following additional features:
How I did it
Corequisite PRs
sonic-net/sonic-mgmt-framework#86
sonic-net/sonic-mgmt-common#49
How to verify it
Execute the Unit Test procedure described in the HLD for this feature:
unit_test_log_0607.txt
Which release branch to backport (provide reason below if selected)
N/A
Description for the changelog
Add Management Framework functionality for "show tech-support".
A picture of a cute animal (not mandatory but encouraged)