Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mgmt reorg -- submodule and build rules for sonic-mgmt-common #4765

Merged
merged 5 commits into from
Jun 22, 2020

Conversation

sachinholla
Copy link
Contributor

- Why I did it
New repo sonic-mgmt-common is introduced for the common translib related code. This commit adds build rules for this new repo.

- How I did it

  1. Added sonic-mgmt-common submodule
  2. Added build rules for the new sonic-mgmt-common repo. It creates two deb packages -- sonic-mgmt-common_1.0.0_{arch}.deb and sonic-mgmt-common-codegen_1.0.0_{arch}.deb. Package cache is enabled.
  3. Added dependency on sonic-mgmt-common for mgmt-framework and telemetry debs and dockers.

- How to verify it
Full build and incremental builds
Basic ACL and interface opreations through REST, KLISH CLI and gNMI

- Description for the changelog
Git submodule and build rules for the new sonic-mgmt-common repo.

1) Added build rules for the new sonic-mgmt-common repo. It creates
two deb packages -- sonic-mgmt-common_1.0.0_{arch}.deb and
sonic-mgmt-common-codegen_1.0.0_{arch}.deb. Package cache is enabled.

2) Added dependency on sonic-mgmt-common for mgmt-framework and
telemetry debs and dockers.
@renukamanavalan
Copy link
Contributor

retest vsimage please

5 similar comments
@renukamanavalan
Copy link
Contributor

retest vsimage please

@renukamanavalan
Copy link
Contributor

retest vsimage please

@renukamanavalan
Copy link
Contributor

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Jun 22, 2020

retest vsimage please

@renukamanavalan
Copy link
Contributor

retest vsimage please

@renukamanavalan
Copy link
Contributor

Expect, last failed build to have done the required cleanup

@renukamanavalan renukamanavalan merged commit 0d809d0 into sonic-net:master Jun 22, 2020
@sachinholla sachinholla deleted the mgmt-reorg branch October 12, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants