Convert docker-snmp-sv2 to buster #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
check the vsimage test, the snmp-subagent is dead. looks like there are some issues during the buster upgrade. can you verify the snmp-subagent is running after your upgrade? |
lguohan
reviewed
May 4, 2020
src/snmpd/patch-5.7.3+dfsg/0009-fix-compilation-in-buster-env.patch
Outdated
Show resolved
Hide resolved
lguohan
reviewed
May 4, 2020
qiluo-msft
reviewed
May 4, 2020
qiluo-msft
reviewed
May 4, 2020
qiluo-msft
reviewed
May 4, 2020
qiluo-msft
reviewed
May 4, 2020
src/snmpd/patch-5.7.3+dfsg/0009-fix-compilation-in-buster-env.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
requested changes
May 4, 2020
pavel-shirshov
suggested changes
May 4, 2020
qiluo-msft
reviewed
May 5, 2020
|
looks like snmp-subagent is still dead. |
This requires a fix in snmpagent - sonic-net/sonic-snmpagent#130 |
|
retest vsimage please |
|
retest broadcom please |
|
You may need to advance submodule of snmpagent in another PR or in this PR. |
Thanks. I have to do it in this PR. Otherwise, the test will not pass. |
|
retest broadcom please |
Not sure why build is failing due to space issue. |
|
retest broadcom please |
qiluo-msft
reviewed
May 8, 2020
|
retest broadcom please |
1 similar comment
|
retest broadcom please |
lguohan
previously approved these changes
May 13, 2020
pavel-shirshov
previously approved these changes
May 13, 2020
libtool: link: gcc -DNETSNMP_ENABLE_IPV6 -fno-strict-aliasing -g -O2 -fdebug-prefix-map=/sonic/src/snmpd/net-snmp-5.7.3+dfsg=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -DNETSNMP_USE_INLINE -Ulinux -Dlinux=linux -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/lib/x86_64-linux-gnu/perl/5.28/CORE -o .libs/snmptrapd .libs/snmptrapd.o -specs=/usr/share/dpkg/no-pie-link.specs -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-E ./.libs/libnetsnmptrapd.so ../agent/.libs/libnetsnmpmibs.so ../agent/.libs/libnetsnmpagent.so ../snmplib/.libs/libnetsnmp.so -L/usr/lib/x86_64-linux-gnu/ -lmariadb -lnl-3 -lm -lwrap /usr/bin/ld: ./.libs/libnetsnmptrapd.so: undefined reference to `load_defaults' /usr/bin/ld: ./.libs/libnetsnmptrapd.so: undefined reference to `my_init' collect2: error: ld returned 1 exit status make[5]: *** [Makefile:297: snmptrapd] Error 1 make[5]: Leaving directory '/sonic/src/snmpd/net-snmp-5.7.3+dfsg/apps' make[4]: *** [Makefile:657: subdirs] Error 1 make[4]: Leaving directory '/sonic/src/snmpd/net-snmp-5.7.3+dfsg' dh_auto_build: make -j1 returned exit code 2 make[3]: *** [debian/rules:65: override_dh_auto_build] Error 2 make[3]: Leaving directory '/sonic/src/snmpd/net-snmp-5.7.3+dfsg' make[2]: *** [debian/rules:41: binary] Error 2 make[2]: Leaving directory '/sonic/src/snmpd/net-snmp-5.7.3+dfsg' make[1]: *** [Makefile:19: /sonic/target/debs/buster/libsnmp-base_5.7.3+dfsg-1.5_all.deb] Error 2 Fix: The definitions of load_defaults and my_init don't exist and hence commenting out their use Signed-off-by: Joyas Joseph <[email protected]>
use python3 provided by buster Signed-off-by: Joyas Joseph <[email protected]>
Signed-off-by: Joyas Joseph <[email protected]>
Signed-off-by: Joyas Joseph <[email protected]>
- Remove python3-dev (actual installed package) instead of libpython3-dev Signed-off-by: Joyas Joseph <[email protected]>
Signed-off-by: Joyas Joseph <[email protected]>
This reverts commit d808ebe.
Signed-off-by: Guohan Lu <[email protected]>
lguohan
force-pushed
the
docker-snmpd-buster
branch
from
3d86380 to
61e3c6a
Compare
qiluo-msft
reviewed
May 14, 2020
qiluo-msft
approved these changes
May 14, 2020
|
@joyas-joseph Could you also remove rules/python3.dep? |
Yes. Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
This is an enhancement.
- How I did it
Code changes
- How to verify it
Run "snmpwalk -c public -v 2c <node_ip> .1.3.6"
- Description for the changelog
This change converts docker-snmp-sv2 to buster.
The change removes compilation rules for python3.6 as we are using python3.7 provided as part of buster itself.
- A picture of a cute animal (not mandatory but encouraged)