Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logFormatJSON for node-driver-registrar & liveness-probe #338

Closed
dkirrane opened this issue Dec 14, 2020 · 2 comments
Closed

Support logFormatJSON for node-driver-registrar & liveness-probe #338

dkirrane opened this issue Dec 14, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@dkirrane
Copy link

dkirrane commented Dec 14, 2020

Describe the solution you'd like
Currently secret-store & provider-aure-installer containers support JSON logging format.

This is a feature request to add the same for the other containers in the key-vault-csi-secrets-store-csi-driver Pod.

  • node-driver-registrar
  • liveness-probe

Environment:

  • Secrets Store CSI Driver version: (use the image tag): helm.sh/chart: secrets-store-csi-driver-0.0.17
  • Azure Key Vault provider version: (use the image tag): helm.sh/chart: csi-secrets-store-provider-azure-0.0.14
  • Kubernetes version: (use kubectl version): v1.19.3
  • Cluster type: (e.g. AKS, aks-engine, etc): AKS
@dkirrane dkirrane added the enhancement New feature or request label Dec 14, 2020
@aramase
Copy link
Member

aramase commented Dec 14, 2020

@dkirrane Thank you for opening the issue. These 2 components are owned by the kubernetes-csi community. I've opened PR to add support for it in both the components:

@aramase
Copy link
Member

aramase commented Dec 14, 2020

I'm closing this issue because it's not owned by us. You can follow the issues: kubernetes-csi/livenessprobe#97 and kubernetes-csi/node-driver-registrar#128 in addition to the PRs to track progress of this support.

@aramase aramase closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants