[BUG] SLES 15 SP3 - Deploy control plane - some issues in the "configure_deployer.sh" script

[amach4]

According to my tests using PAYG SLES 15 SP3 based image for the deployer instance, the script "configure_deployer.sh" has some issues and needs to be modified for official SLES 12/15 based Azure images.

Steps to reproduce the behavior:

Deploy control plane - https://learn.microsoft.com/en-us/azure/virtual-machines/workloads/sap/automation-deploy-control-plane?tabs=linux#deploy-the-control-plane-1

Modified Deployer configuration file "MGMT-WEEU-DEP00-INFRASTRUCTURE.tfvars":

# The deployer_image defines the Virtual machine image to use, if source_image_id is specified the deployment will use the custom image provided, in this case os_type must also be specified

deployer_image = {
"os_type" = "Linux"
"source_image_id" = ""
"publisher" = "suse"
"offer" = "sles-15-sp3"
"sku" = "gen2"
"version" = "latest"
}

---

Here the diff for the script "deploy/scripts/configure_deployer.sh"

Issue 1:
Wrong zypper command options used

- sudo ${pkg_mgr} --gpg-auto-import-keys --quiet upgrade
+ sudo ${pkg_mgr} --gpg-auto-import-keys --non-interactive patch

---

Issue 2:
The package "sshpass" is available in SUSE Package Hub 15 SP3 repository, this repo is not activated in the SLES 15 SP3 based images available on Azure.
The package "apt-transport-https" is not available in official SLES 15 SP3 repositories.

- apt-transport-https
+# apt-transport-https

- sshpass
+# sshpass

---

Issue 3:
Command not needed with SLES 12/15 based deployer image

- curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash > /dev/null
+# curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash > /dev/null

---

Issue 4:
Verification if extension "configure_deployer" is installed failed

- devops_extension_installed=$(az extension list --query [].path | grep azure-devops)
- if [ -z $devops_extension_installed ]; then
- az extension add --name azure-devops --output none
+ if az extension list --query [].path | grep -q "azure-devops"; then
+ echo 'Azure "azure-devops" extension is already installed'
+ else
+ echo 'Azure "azure-devops" extension is missing and has to be installed'
+ az extension add --name azure-devops --output none

---

NOTE: This is what was used to successfully deploy the control plane, using PAYG SLES 15 SP3 based deployer image.

[amach4]

renamed "configure_deployer.sh" script example:
configure_deployer.sh.txt

[KimForss]

Thanks @amach4 Will add this to release 3.9 (scheduled in the next 2 weeks)