Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename labelnamespaces variable to ignoreNamespaces #111

Open
draychev opened this issue Jun 17, 2021 · 1 comment
Open

Rename labelnamespaces variable to ignoreNamespaces #111

draychev opened this issue Jun 17, 2021 · 1 comment
Assignees
@nshankar13 @SanyaKochhar @ksubrmnn
Labels
good first issue Good for newcomers

Comments

@draychev
Copy link
Contributor

The variable name labelnamespaces does not provide enough context around what and why.
I propose we rename labelnamespaces to ignoreNamespaces, which will match the original store of value and most importantly will carry more context.

This needs to be renamed in a few places:

https://github.com/Azure/osm-azure/search?q=labelnamespaces
@draychev
Copy link
Contributor Author

Related issue: #110

@draychev draychev mentioned this issue Jun 17, 2021
Open
@draychev draychev added the good first issue Good for newcomers label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshankar13 nshankar13

@SanyaKochhar SanyaKochhar

@ksubrmnn ksubrmnn

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nshankar13 @SanyaKochhar @ksubrmnn @draychev