Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a type that was previously missing is breaking #167

Closed
johnthcall opened this issue May 7, 2020 · 2 comments
Closed

Adding a type that was previously missing is breaking #167

johnthcall opened this issue May 7, 2020 · 2 comments

Comments

@johnthcall
Copy link
Member

We had complaints from a user that our swagger was missing a type field. When we tried to add it the breaking changes trigger because the types differ. I don't know for sure if it is a real breaking change but will raise a PR in case it is a false positive.

id: '1026',
code: 'TypeChanged',
message: "The new version has a different type 'object' than the previous one ''.",
Azure/azure-rest-api-specs#9215

@ruowan
Copy link
Member

ruowan commented May 14, 2020

Thanks for the feedback. It is actually breaking change not false positive. Schema without type means all types are allowed. When you add type object, you constrain the type to object as a result, the property can't receive any other types.

@johnthcall
Copy link
Member Author

Thanks for the explanation, it was a little unclear from the error messages we received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants