Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed subnet for storage private endpoints #979

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

jamasten
Copy link
Contributor

The private endpoints and NICs for the storage accounts were being added to the HUB VNET. Which only works when the HUB and target tier are in the same subscription. A customer was attempting to deploy to multiple subs and discovered this failure. The subnet resource ID has been updated to target the subnet in the target tier.

@jamasten jamasten added bug Something isn't working bicep Related to Bicep code labels Apr 10, 2024
@jamasten jamasten self-assigned this Apr 10, 2024
@jamasten jamasten requested a review from a team as a code owner April 10, 2024 22:51
@jamasten jamasten linked an issue Apr 10, 2024 that may be closed by this pull request
@jamasten jamasten enabled auto-merge (squash) April 10, 2024 22:51
@jamasten jamasten merged commit 2587efb into main Apr 11, 2024
1 check passed
@jamasten jamasten deleted the 978-mlz-private-endpoints-targeting-wrong-subnet branch April 11, 2024 01:34
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
* Fixed subnet ID

* Added deployment name suffix to storage deployment

* Fixed deployment name

* Compiled bicep changes

* GitHub Action: Build Bicep to JSON

---------

Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bicep Related to Bicep code bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLZ: Private endpoints targeting wrong subnet
2 participants