Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KV logs and re-adjust log analytics workspace retention/remove locks #941

Merged
merged 13 commits into from
Mar 28, 2024

Conversation

jayhaddad
Copy link
Contributor

Description

  1. Added key vault diagnostic logging
  2. Changed log analytics workspace retention to 90 days only if Sentinel is deployed. A sentinel-linked workspace includes 90 days of retention.
  3. Removed from bicep module the ability to configure locks on log analytics workspace. This is not a recommended practice from Microsoft, as it can interfere with some housekeeping operations.

Issue reference

The issue this PR will close: #937 #936 #940

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@jayhaddad jayhaddad requested a review from a team as a code owner March 27, 2024 15:38
@jamasten jamasten merged commit 3c1851a into main Mar 28, 2024
2 of 3 checks passed
@jamasten jamasten deleted the keyvaultlogs branch March 28, 2024 02:52
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
…cks (Azure#941)

* added key vault logging

* update array for diagnostic settings keyvault

* recomplie bicep

* added storageaccount for kv

* recompile arm bicep template

* GitHub Action: Build Bicep to JSON

* remove lock on log analytics workspace to fall inline with guidance

* added conditional logic to change workspace retention based on sentinel deployment

* revised retention variable logic

* compiled bicep

* GitHub Action: Build Bicep to JSON

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: Jason Masten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants