-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KV logs and re-adjust log analytics workspace retention/remove locks #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamasten
approved these changes
Mar 28, 2024
This was
linked to
issues
Mar 28, 2024
This was referenced Mar 28, 2024
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
…cks (Azure#941) * added key vault logging * update array for diagnostic settings keyvault * recomplie bicep * added storageaccount for kv * recompile arm bicep template * GitHub Action: Build Bicep to JSON * remove lock on log analytics workspace to fall inline with guidance * added conditional logic to change workspace retention based on sentinel deployment * revised retention variable logic * compiled bicep * GitHub Action: Build Bicep to JSON --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Jason Masten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue reference
The issue this PR will close: #937 #936 #940
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: