add NSG flow logs and remove network watcher module #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Flow Log variables to subnet module - Added subnet module inputs to tier-0 deployment - Added outputs to Network Watcher module
- Changed name format for flow log resource - Removed name inputs in subnet main
- Removed networkwatcher resource from saca-hub - Removed networkwatcher resource from tier-0 - Removed networkwatcher resource from tier-1 - Removed networkwatcher resource from tier-2 - Modified all tier tfvars templates to remove networkwatcher
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Network Watcher resources get created automatically (by default) when the first virtual network is created in a region. The platform only allows for a single NetworkWatcherRG resource group per subscription and a single Network Watcher per region within a sub.
This branch removes the code that would create a Network Watcher resource group and resource, removes the Network Watcher Terraform module, removes the create_network_watcher parameter from the tfvars sample templates, and adds the NSG Flow Log resource to the subnets module using the default platform generated names for Network Watcher resource groups and resources.
Issue reference
The issue this PR will close: #66
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)