Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defender fix #802

Merged
merged 4 commits into from
Jan 16, 2024
Merged

defender fix #802

merged 4 commits into from
Jan 16, 2024

Conversation

mikedzikowski
Copy link
Contributor

@mikedzikowski mikedzikowski commented Jan 16, 2024

Description

Updated defender.bicep and fixed issue with security contacts resource:

resource securityNotifications 'Microsoft.Security/securityContacts@2020-01-01-preview' = if (!empty(emailSecurityContact)) { **name: 'default'** properties: { notificationsByRole: { roles: [ 'AccountAdmin' 'Contributor' 'Owner' 'ServiceAdmin' ] state: 'On' } alertNotifications: { state: 'On' } emails: emailSecurityContact } }

Issue reference

The issue this PR will close: #[issue number]
#801

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@mikedzikowski mikedzikowski requested a review from a team as a code owner January 16, 2024 20:23
@kyle-hoyer kyle-hoyer merged commit 059a5a5 into main Jan 16, 2024
1 check passed
@kyle-hoyer kyle-hoyer deleted the dzikowski-defenderfix branch January 16, 2024 20:26
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
* fix

* test fix

* json update

* GitHub Action: Build Bicep to JSON

---------

Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants