Generate uniqueData for Private Link resources in an idempotent manner #748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current method for generating
uniqueData
for use in naming resources prevents idempotent deployment because an attempt to create a new AMPLS resource results in a conflict with the previous one. This additionally leads to multiple private endpoints getting created, which could eventually exhaust IP space in the subnet over time if deployed enough times.I propose that if this is generated using the
uniqueString
Bicep function instead, the random string will be generated in a repeatable manner, provided future deployments are both to the same subscription, and with the same deployment name. Manual testing in an Azure Gov subscription seems good as far as I can tell.Relevant change is to L22. The remainder are corrections to whitespace by the Bicep plugin in VS Code.
Issue reference
The issue this PR will close: #700
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: