Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AMPLS to Operations Tier #739

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Move AMPLS to Operations Tier #739

merged 5 commits into from
Aug 29, 2022

Conversation

FabienGilbert
Copy link
Contributor

Description

Moved the AMPLS and its Private Endpoint to the Operations tier, so that it sits together with the Log Analytics Workspace. This includes the following changes:

  1. Moved the Private DNS zones creation out of the private-link module and into its own module, so that the zones still get created in the Hub.
  2. Added a parameter for the VNET Subnet PrivateEndpointNetworkPolicies setting in the spoke module, so that the Operations VNET subnet get created with that setting disabled.
  3. Moved the Private DNS zones and the AMPLS creation out of the hub module and into the main template, so that they can be deployed to different tiers.

Issue reference

The issue this PR will close: #738

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@FabienGilbert FabienGilbert requested a review from a team as a code owner August 24, 2022 20:11
lisamurphy-msft
lisamurphy-msft approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This provides a more streamlined approach with logical separation of resources.
Extensive testing proved successful and I see no reason not to approve this PR

@lisamurphy-msft
Copy link
Contributor

/azp run

@lisamurphy-msft lisamurphy-msft merged commit 9a63fa4 into Azure:main Aug 29, 2022
@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@lisamurphy-msft lisamurphy-msft added the core New feature or request label Sep 8, 2022
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
@FabienGilbert
Move AMPLS to Operations Tier (Azure#739)
6ba9e5a 
* removed AMPLS deployment

* support for subnet PrivateEndpointNetworkPolicies

* removed private DNS zones deployment

* new module for private DNS zones creation

* moved AMPLS PV Endpoint to OPS;PV DNS zones to HUB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisamurphy-msft lisamurphy-msft lisamurphy-msft approved these changes

Assignees
No one assigned
Labels
core New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AMPLS Private Endpoint connected to Hub VNET
2 participants
@FabienGilbert @lisamurphy-msft