-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tier3.bicep Adding Defender configuration to Tier 3 #725
Update tier3.bicep Adding Defender configuration to Tier 3 #725
Conversation
Thank you for updating this. I propose that you also update the README located here to include the additional optional parameter you are proposing be added to the Tier3 deployment. |
Will do. Thank you |
Pulling Defender info from the core mlz.bicep deployment Updating Tier 3 Readme
Fixing error with duplicate parameters. Adding Moving description comments to the parameters that pull from mlzDeploymentVariables
@lisamurphy-msft Thank you for your time and help with this! Note: Out of the 24 original variables, 22 are not in the readme. Should that be brought up in a different issue? Parameters in the ReadMe Parameters not in the Readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comment included; this will slightly change the outputs listed in the documentation for a base MLZ deployment. While this is not a breaking change, it should be fixed to ensure accuracy.
We are adding additional outputs to the MLZ baseline; this is to incorporate adding in outputs for the deploymentVariables.json for Tier3.
While this isn't a big change, we should probably ensure that the outputs listed in the README.md of the MissionLZ bicep code include the outputs linked in the outputs documentation
Please add to the list:
deployDefender.value
emailSecurityContact.value
Adding New Outputs to the Bicep Core Readme Documentation
…Manning-Dev/missionlz into loganmanning/tier3defender_723
Failing the Linting check; will investigate. |
… they are inherited With the inheritance pattern proposed in this PR, this will not be necessary to explicitly state here. The state of just using the same default configuration in the original MLZ deployment will be sufficient with the added changes of documenting the additional two outputs.
Thank you for updating as requested; this looks good! |
* Update tier3.bicep * Tier 3 Defender Update Pulling Defender info from the core mlz.bicep deployment Updating Tier 3 Readme * Update Tier3. Removing Duplicate parameters and moving comments up Fixing error with duplicate parameters. Adding Moving description comments to the parameters that pull from mlzDeploymentVariables * Adding New Outputs to the Bicep Core Readme Documentation Adding New Outputs to the Bicep Core Readme Documentation * Removing parameters from the Tier3 Readme that are not needed because they are inherited With the inheritance pattern proposed in this PR, this will not be necessary to explicitly state here. The state of just using the same default configuration in the original MLZ deployment will be sufficient with the added changes of documenting the additional two outputs. Co-authored-by: lisamurphy-msft <[email protected]>
Description
Added Defender Configuration used in mlz.bicep into the tier 3
Issue reference
The issue this PR will close: #723
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: