Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aks bicep module #718

Merged
merged 9 commits into from
Sep 13, 2022
Merged

Conversation

renato-marciano
Copy link
Contributor

@renato-marciano renato-marciano commented Jun 3, 2022

Description

Added AKS bicep module.
Added a ReadMe with example of deploying AKS to Tier 3.

Issue reference

The issue this PR is linked to: #669
Will not close this issue, since the issue also asks for ACR and simple app deployment.

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

Co-authored-by: @olhakonst17

@renato-marciano renato-marciano requested a review from a team as a code owner June 3, 2022 20:23
@olhakonst17
Copy link
Contributor

@mission-lz-reviewers Please let us know if there is any additional details needed on this PR for it to be reviewed. Thanks!

cc: @renato-marciano

@lisamurphy-msft
Copy link
Contributor

Thank you for providing this PR @renato-marciano and @olhakonst17
Unfortunately, this will need to be moved to the
https://github.com/Azure/missionlz/tree/main/src/bicep/examples folder with an added description in the containing README.md and a subfolder with all the artifacts needed. Are you able to move this to the requested folder?

@lisamurphy-msft lisamurphy-msft added the examples Related to content in the `src/bicep/examples` folder label Sep 8, 2022
@renato-marciano
Copy link
Contributor Author

Thank you for providing this PR @renato-marciano and @olhakonst17 Unfortunately, this will need to be moved to the https://github.com/Azure/missionlz/tree/main/src/bicep/examples folder with an added description in the containing README.md and a subfolder with all the artifacts needed. Are you able to move this to the requested folder?

I have moved the files under examples and have made updates. The Git Action on the Pull Request looks like it's failing because of permission issues.

Copy link
Contributor

@lisamurphy-msft lisamurphy-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the requested changes!
Approving this PR.

@lisamurphy-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@lisamurphy-msft lisamurphy-msft enabled auto-merge (squash) September 13, 2022 19:05
@lisamurphy-msft lisamurphy-msft merged commit afe8bd1 into Azure:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to content in the `src/bicep/examples` folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants