-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy App Service Plan - MLZ Example #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Some minor nits and questions. My primary feedback is for allowing for the default parameter override behavior of ARM and Bicep. 👍
src/bicep/examples/appServicePlan/modules/appServiceSettings.bicep
Outdated
Show resolved
Hide resolved
src/bicep/examples/appServicePlan/modules/appServiceSettings.bicep
Outdated
Show resolved
Hide resolved
src/bicep/examples/appServicePlan/modules/appServiceSettings.bicep
Outdated
Show resolved
Hide resolved
Cause I don't know how to show that it's resolved. The requested change has been implemented. :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still reviewing but leaving these simple things here while I do deployments.
Co-authored-by: Brooke Hamilton <[email protected]>
Co-authored-by: Brooke Hamilton <[email protected]>
Co-authored-by: Brooke Hamilton <[email protected]>
Co-authored-by: Brooke Hamilton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the changes. ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployed successfully. Minor changes requested.
Description
This update adds a new example workload deployment. Specifically, it enables the deployment of an App Service Plan suitable for hosting Linux web applications using docker containers. Here are some of the details of the implementation:
Note: This example does not also deploy a web application because the target audience for this particular sample is the engineering/admin team. A separate example showing how to deploy a Linux web app container on docker will be forthcoming which is aimed at the dev team.
This update uses the bicep shared variable file pattern as described here: https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/patterns-shared-variable-file
Issue reference
This PR is related to the following issue: #517
I did attempt to retrieve MLZ outputs using a deployment object, but ultimately failed to successfully do so do the dynamic nature of how the outputs are parsed/discovered at run-time. More research is needed, but felt this pattern solved the majority of the issue and is worthy of doing now while we continue to investigate how to use deployment objects for this problem.
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: