-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add diagnostics settings for firewall, public IP, and network security groups #473
Conversation
Should we make 'metrics' optional since they add expense that may not be required. Should logs even be optional? I thought we were also removing the TF virtual network diagnostic logging in this also, maybe making it an option parameter, |
I don't think logs should be optional, but can see how Metrics might be. If we decide to make Metrics optional, let's do that in a different change in tandem with optional metrics in Terraform so that the implementations are consistent.
There are no logs or metrics configured with the virtual network diagnostic setting resource, but they're opt-in in that a user can provide their own categories if they choose by providing values for those parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as designed.
Description
Defaults the diagnostic logs and metrics settings for these resources:
Azure Firewall
Public IP Address
Network Security Group
Virtual Network
Demo
To demo this, deploy MLZ as you usually would with
az deployment sub create
.You can visually see these diagnostic settings by selecting "Diagnostic Settings" from any of the resource groups. For example, here's a Hub Resource Group Diagnostic Settings blade:
Issue reference
The issue this PR will close: #465
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: